-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(katana-node-bindings): add json log docs #2145
Conversation
Warning Rate limit exceeded@kariy has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 50 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent updates to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- crates/katana/node-bindings/src/json.rs (1 hunks)
Files skipped from review due to trivial changes (1)
- crates/katana/node-bindings/src/json.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lock
is excluded by!**/*.lock
Files selected for processing (4)
- crates/katana/node-bindings/Cargo.toml (1 hunks)
- crates/katana/node-bindings/src/json.rs (1 hunks)
- crates/katana/node-bindings/src/lib.rs (9 hunks)
- crates/katana/runner/src/lib.rs (3 hunks)
Files skipped from review due to trivial changes (1)
- crates/katana/node-bindings/Cargo.toml
Files skipped from review as they are similar to previous changes (1)
- crates/katana/node-bindings/src/json.rs
Additional comments not posted (12)
crates/katana/runner/src/lib.rs (4)
14-14
: Update import statement to useFelt
instead ofFieldElement
The import statement has been updated to replace
FieldElement
withFelt
. This is consistent with the changes mentioned in the summary.
26-26
: Update struct field to useFelt
instead ofFieldElement
The
contract
field in theKatanaRunner
struct has been updated to useFelt
instead ofFieldElement
.
153-154
: Update method signature to useFelt
instead ofFieldElement
The
set_contract
method's parameter type has been updated toFelt
instead ofFieldElement
. This change ensures consistency with the updated type usage.
158-158
: Update method return type to useFelt
instead ofFieldElement
The
contract
method's return type has been updated toFelt
instead ofFieldElement
. This change ensures consistency with the updated type usage.crates/katana/node-bindings/src/lib.rs (8)
16-16
: Update import statement to useFelt
instead ofFieldElement
The import statement has been updated to replace
FieldElement
withFelt
. This is consistent with the changes mentioned in the summary.
32-33
: Update struct field to useFelt
instead ofFieldElement
The
address
field in theAccount
struct has been updated to useFelt
instead ofFieldElement
.
45-45
: Update struct field to useFelt
instead ofFieldElement
The
chain_id
field in theKatanaInstance
struct has been updated to useFelt
instead ofFieldElement
.
65-65
: Update method return type to useFelt
instead ofFieldElement
The
chain_id
method's return type has been updated toFelt
instead ofFieldElement
. This change ensures consistency with the updated type usage.
338-338
: Update builder method parameter type to useFelt
instead ofFieldElement
The
chain_id
builder method's parameter type has been updated toFelt
instead ofFieldElement
. This change ensures consistency with the updated type usage.
511-512
: Update parsing to useFelt
instead ofFieldElement
The parsing of the address and private key has been updated to use
Felt
instead ofFieldElement
. This change ensures consistency with the updated type usage.
550-550
: Update parsing to useFelt
instead ofFieldElement
The parsing of the address has been updated to use
Felt
instead ofFieldElement
. This change ensures consistency with the updated type usage.
569-569
: Update parsing to useFelt
instead ofFieldElement
The parsing of the private key has been updated to use
Felt
instead ofFieldElement
. This change ensures consistency with the updated type usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Summary by CodeRabbit
Documentation
Refactor
FieldElement
withFelt
for better consistency and compatibility.Chores
license
declaration from workspace configuration.