Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(torii-core): add entities deletions to susbcription broker #2106

Merged
merged 3 commits into from
Jun 26, 2024

chore: return empty entities when count 0

cef9fe2
Select commit
Loading
Failed to load commit list.
Merged

feat(torii-core): add entities deletions to susbcription broker #2106

chore: return empty entities when count 0
cef9fe2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 26, 2024 in 0s

68.50% (+0.00%) compared to e87118d

View this Pull Request on Codecov

68.50% (+0.00%) compared to e87118d

Details

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.50%. Comparing base (e87118d) to head (cef9fe2).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/torii/grpc/src/server/mod.rs 28.57% 5 Missing ⚠️
crates/torii/core/src/sql.rs 80.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2106   +/-   ##
=======================================
  Coverage   68.50%   68.50%           
=======================================
  Files         331      331           
  Lines       41280    41337   +57     
=======================================
+ Hits        28278    28319   +41     
- Misses      13002    13018   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.