Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(torii-core): add entities deletions to susbcription broker #2106

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Jun 25, 2024

Closes #2098. This PR integrates entities deletions into the entities subscription (returns empty models for deleted entities) and deletes the entity reference when an entity gets deleted

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.50%. Comparing base (e87118d) to head (cef9fe2).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/torii/grpc/src/server/mod.rs 28.57% 5 Missing ⚠️
crates/torii/core/src/sql.rs 80.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2106   +/-   ##
=======================================
  Coverage   68.50%   68.50%           
=======================================
  Files         331      331           
  Lines       41280    41337   +57     
=======================================
+ Hits        28278    28319   +41     
- Misses      13002    13018   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Larkooo Larkooo merged commit b04c0d7 into dojoengine:main Jun 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useEntityQuery returns deleted entities
2 participants