Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(torii-grpc): support multiple entity models in queries & complex keys clause for subscriptions + queries #2095

Merged
merged 28 commits into from
Jun 27, 2024

refactor: use array of models for keysclause

48c9c2e
Select commit
Loading
Failed to load commit list.
Merged

feat(torii-grpc): support multiple entity models in queries & complex keys clause for subscriptions + queries #2095

refactor: use array of models for keysclause
48c9c2e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 27, 2024 in 0s

68.34% (-0.17%) compared to b04c0d7

View this Pull Request on Codecov

68.34% (-0.17%) compared to b04c0d7

Details

Codecov Report

Attention: Patch coverage is 16.51163% with 359 lines in your changes missing coverage. Please review.

Project coverage is 68.34%. Comparing base (b04c0d7) to head (48c9c2e).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/torii/grpc/src/server/mod.rs 36.74% 105 Missing ⚠️
...ates/torii/grpc/src/server/subscriptions/entity.rs 0.00% 76 Missing ⚠️
...rii/grpc/src/server/subscriptions/event_message.rs 0.00% 65 Missing ⚠️
crates/torii/grpc/src/types/mod.rs 1.96% 50 Missing ⚠️
...rates/torii/grpc/src/server/subscriptions/event.rs 0.00% 35 Missing ⚠️
crates/torii/client/src/client/mod.rs 0.00% 14 Missing ⚠️
crates/torii/grpc/src/client.rs 0.00% 9 Missing ⚠️
crates/torii/core/src/sql.rs 0.00% 3 Missing ⚠️
crates/torii/client/src/client/subscription.rs 83.33% 1 Missing ⚠️
.../torii/grpc/src/server/subscriptions/model_diff.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2095      +/-   ##
==========================================
- Coverage   68.50%   68.34%   -0.17%     
==========================================
  Files         331      331              
  Lines       41337    41443     +106     
==========================================
+ Hits        28319    28323       +4     
- Misses      13018    13120     +102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov