-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(torii-grpc): support multiple entity models in queries & complex keys clause for subscriptions + queries #2095
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2095 +/- ##
==========================================
- Coverage 68.50% 68.34% -0.17%
==========================================
Files 331 331
Lines 41337 41443 +106
==========================================
+ Hits 28319 28323 +4
- Misses 13018 13120 +102 ☔ View full report in Codecov by Sentry. |
73c46fa
to
7102292
Compare
b5b4a0f
to
c44b1d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
adds support for KeysClause on subscriptions, to match all entities with a certain key pattern. This will allow for more control over the subscriptions. Like subscribing for entities with a specific game_id or a pattern of specific keys.
Also refactor the entities queries to reuse them for subscriptions and oher small changes. The new entities queries use the complex keys clause that can take in a key pattern with a pattern matching type for complex keys queries.
This also makes the queries support entities of multiple models, like an entity with Game model and entities with PlayerGame + PlayerPosition models.
Related issue
#1983