-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Katana] Allow choosing the class in the genesis file without affecting the actual class hash #1975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey sorry for not being too active on this PR!
thanks for the work! its looking good so far, just have some few feedbacks. but overall its looking great!
i've also took the liberty to add some changes in 8403a27 . basically adding a custom deserializer for the because both are parsed as string in the JSON format, we need to do distinguish between when user set an actual class hash (with |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1975 +/- ##
==========================================
- Coverage 69.73% 69.70% -0.04%
==========================================
Files 314 314
Lines 35654 35766 +112
==========================================
+ Hits 24864 24931 +67
- Misses 10790 10835 +45 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice it looks good! i've helped added some stuff and just some styling
thanks!!
Description
Add a name field in GenesisClassJson that allows class identification by a unique name rather than by hash in Katana
Related issue
Fixes #<#1502>
Tests
Added to documentation?
Checklist
scripts/prettier.sh
,scripts/rust_fmt.sh
,scripts/cairo_fmt.sh
)scripts/clippy.sh
,scripts/docs.sh
)