Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Katana] Allow choosing the class in the genesis file without affecting the actual class hash #1972

Closed
wants to merge 3 commits into from

Conversation

Yogalholic
Copy link
Contributor

Description

Add a name field in GenesisClassJson that allows class identification by a unique name rather than by hash in Katana

Related issue

Fixes #<#1502>

Tests

  • [x ] Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • [x ] No documentation needed

Checklist

  • [x ] I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • [ x] I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • [ x] I've commented my code
  • [ x] I've requested a review after addressing the comments

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 66.21622% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 69.72%. Comparing base (de3b2e5) to head (da71a89).

Files Patch % Lines
crates/katana/primitives/src/genesis/json.rs 66.21% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1972      +/-   ##
==========================================
- Coverage   69.80%   69.72%   -0.08%     
==========================================
  Files         313      313              
  Lines       35526    35579      +53     
==========================================
+ Hits        24798    24808      +10     
- Misses      10728    10771      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yogalholic Yogalholic closed this May 16, 2024
@Yogalholic
Copy link
Contributor Author

I have opened the final PR here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant