Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple benchmark for the transact function #1969

Merged
merged 10 commits into from
May 16, 2024
Merged

Add simple benchmark for the transact function #1969

merged 10 commits into from
May 16, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented May 15, 2024

Description

a simple benchmark for the smallest unit of execution that. we use the pprof profiler to output a flamegraph.

we can later extend this to sir once we have it re-enabled it.

Related issue

Tests

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

@kariy
Copy link
Member Author

kariy commented May 15, 2024

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 55.97015% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 69.73%. Comparing base (49f0a4e) to head (bbe2d7c).
Report is 2 commits behind head on main.

Current head bbe2d7c differs from pull request most recent head 63d2af4

Please upload reports for the commit 63d2af4 to get more accurate results.

Files Patch % Lines
crates/katana/storage/provider/src/test_utils.rs 0.00% 49 Missing ⚠️
...tana/executor/src/implementation/blockifier/mod.rs 79.16% 5 Missing ⚠️
crates/katana/executor/src/abstraction/mod.rs 0.00% 3 Missing ⚠️
...na/executor/src/implementation/blockifier/utils.rs 98.11% 1 Missing ⚠️
crates/katana/executor/src/utils.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1969      +/-   ##
==========================================
- Coverage   69.81%   69.73%   -0.08%     
==========================================
  Files         313      314       +1     
  Lines       35562    35631      +69     
==========================================
+ Hits        24828    24848      +20     
- Misses      10734    10783      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy changed the title add criterion and pprof Add simple benchmark for the transact function May 15, 2024
@kariy kariy force-pushed the single-exec-unit branch from 55905e7 to 87d6943 Compare May 16, 2024 15:27
@kariy kariy force-pushed the executor-benchmark branch from 94675c5 to bbe2d7c Compare May 16, 2024 15:27
@kariy
Copy link
Member Author

kariy commented May 16, 2024

Merge activity

  • May 16, 3:54 PM EDT: @kariy started a stack merge that includes this pull request via Graphite.
  • May 16, 3:59 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 16, 4:00 PM EDT: @kariy merged this pull request with Graphite.

@kariy kariy force-pushed the single-exec-unit branch from 87d6943 to e202651 Compare May 16, 2024 19:56
Base automatically changed from single-exec-unit to main May 16, 2024 19:58
@kariy kariy force-pushed the executor-benchmark branch from bbe2d7c to 63d2af4 Compare May 16, 2024 19:59
@kariy kariy merged commit c9714ef into main May 16, 2024
10 of 11 checks passed
@kariy kariy deleted the executor-benchmark branch May 16, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant