Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(katana): provider test utils #1967

Merged
merged 7 commits into from
May 16, 2024
Merged

test(katana): provider test utils #1967

merged 7 commits into from
May 16, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented May 15, 2024

Description

Test utilities for when we need to instantiate the providers with predefined initial states that are useful for testing/benchmarking purposes.

Related issue

Tests

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

@kariy
Copy link
Member Author

kariy commented May 15, 2024

@kariy kariy changed the title wip test(katana): provider test utils May 15, 2024
@kariy kariy marked this pull request as ready for review May 15, 2024 14:13
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes are missing coverage. Please review.

Project coverage is 69.71%. Comparing base (49f0a4e) to head (1b3c1d6).

Files Patch % Lines
crates/katana/storage/provider/src/test_utils.rs 0.00% 49 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1967      +/-   ##
==========================================
- Coverage   69.81%   69.71%   -0.10%     
==========================================
  Files         313      314       +1     
  Lines       35562    35611      +49     
==========================================
- Hits        24828    24827       -1     
- Misses      10734    10784      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy force-pushed the prov-test-utils2 branch from 78adfeb to 1b3c1d6 Compare May 16, 2024 15:27
@kariy
Copy link
Member Author

kariy commented May 16, 2024

Merge activity

  • May 16, 3:54 PM EDT: @kariy started a stack merge that includes this pull request via Graphite.
  • May 16, 3:55 PM EDT: @kariy merged this pull request with Graphite.

@kariy kariy merged commit 8c6df7b into main May 16, 2024
21 of 24 checks passed
@kariy kariy deleted the prov-test-utils2 branch May 16, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant