Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(katana): make genesis and gas price cli args conflicting #1745

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Apr 1, 2024

ref #1744

to limit and simplify how gas prices can be set in katana.

currently there are two ways to do this:

  1. using the --*-gas-price cli arg
  2. set in the genesis config

this change only allow the gas price to be set using one way or the other and not through a combination of both (eg pass a genesis config but set gas prices in cli) which makes it counterintuitive imo

@kariy
Copy link
Member Author

kariy commented Apr 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kariy and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.05%. Comparing base (a23a0c6) to head (db16b85).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1745   +/-   ##
=======================================
  Coverage   68.05%   68.05%           
=======================================
  Files         304      304           
  Lines       32950    32950           
=======================================
  Hits        22424    22424           
  Misses      10526    10526           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy changed the title make genesis and gas price cli args conflicting for now refactor(katana): make genesis and gas price cli args conflicting for now Apr 1, 2024
@kariy kariy marked this pull request as ready for review April 1, 2024 12:26
Base automatically changed from fix-gas-price to main April 1, 2024 16:49
@kariy kariy changed the title refactor(katana): make genesis and gas price cli args conflicting for now refactor(katana): make genesis and gas price cli args conflicting Apr 1, 2024
@kariy kariy merged commit b952d0f into main Apr 1, 2024
21 of 22 checks passed
@kariy kariy deleted the cli-update branch April 1, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant