fix(katana): block env wrongly updated with cli value #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1744 +/- ##
==========================================
+ Coverage 68.01% 68.06% +0.04%
==========================================
Files 304 304
Lines 32912 32950 +38
==========================================
+ Hits 22385 22426 +41
+ Misses 10527 10524 -3 ☔ View full report in Codecov by Sentry. |
kariy
changed the title
kariy
commented
Apr 1, 2024
| @@ -179,7 +179,6 @@ impl<EF: ExecutorFactory> Backend<EF> { | |||
|
|
|||
| block_env.number += 1; | |||
| block_env.timestamp = timestamp; | |||
| block_env.l1_gas_prices = self.config.env.gas_price.clone(); | |||
There was a problem hiding this comment.
if this line is not removed, the updated tests would fail
|
cc @broody can you test on this pr |
|
@kariy confirmed issue fixed, thx! Appreciate another alpha release with this |
kariy
added a commit
that referenced
this pull request
Apr 1, 2024
) ref #1744 to limit and simplify how gas prices can be set in katana. currently there are two ways to do this: 1. using the `--*-gas-price` cli arg 2. set in the genesis config this change only allow the gas price to be set using one way or the other and not through a combination of both (eg pass a genesis config but set gas prices in cli) which makes it counterintuitive imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1724
updated the test to make sure the gas prices doesn't get modified with the cli value in the
update_block_envmethod.now actual tx execution would result in a similar fee value that you get when doing fee estimation