Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rust to 1.76.0 #1720

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Bump rust to 1.76.0 #1720

merged 6 commits into from
Mar 29, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Mar 28, 2024 •
edited
Loading

bump rust to 1.76.0 and apply the new clippy warnings

@kariy
Copy link
Member Author

kariy commented Mar 28, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kariy and the rest of your teammates on Graphite Graphite

@kariy kariy changed the title bump rust to 1.76.0 Bump rust to 1.76.0 Mar 28, 2024
@kariy kariy marked this pull request as ready for review March 28, 2024 13:17
@kariy kariy mentioned this pull request Mar 28, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.00000% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 68.58%. Comparing base (57fa2dc) to head (77eb3ac).

Files Patch % Lines
crates/katana/primitives/src/utils/transaction.rs 0.00% 31 Missing ⚠️
...rates/katana/core/src/service/messaging/service.rs 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1720      +/-   ##
==========================================
+ Coverage   68.46%   68.58%   +0.11%     
==========================================
  Files         295      295              
  Lines       31818    32164     +346     
==========================================
+ Hits        21784    22059     +275     
- Misses      10034    10105      +71

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kariy
kariy commented Mar 28, 2024
View reviewed changes
Copy link
Member Author

@kariy kariy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

birdbox

@kariy kariy requested a review from glihm March 28, 2024 14:55
glihm
glihm approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, SHIP IT!

@kariy kariy merged commit 8d66222 into main Mar 29, 2024
11 of 12 checks passed
@kariy kariy deleted the bump-rust-176 branch March 29, 2024 06:19
@kariy kariy mentioned this pull request Mar 29, 2024
Merged
kariy added a commit that referenced this pull request Mar 29, 2024
@kariy
Re-export reth-metrics-derive crate from dojo-metrics (#1719)
48e7261 
ref #1369

- re-export [reth-metrics-derive](https://github.com/paradigmxyz/reth/tree/v0.2.0-beta.4/crates/metrics/metrics-derive) crate from dojo-metrics
- rename metrics -> dojo-metrics crate
- re-export core metrics stuff from dojo-metrics

---

this PR relies on #1720 bcs reth's MSRV is 1.76.0, otherwise can't build reth-metrics-derive.
This was referenced Mar 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glihm glihm glihm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kariy @glihm