Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(katana-core): dont use optional dep in non-feature specific code #1746

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Apr 1, 2024

before this, running cargo test -p katana-core would result in error bcs we're using ethers crate in non-feature code

ref #1527

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.01%. Comparing base (48e7261) to head (8d0f6ca).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1746      +/-   ##
==========================================
- Coverage   68.69%   68.01%   -0.68%     
==========================================
  Files         296      304       +8     
  Lines       32342    32912     +570     
==========================================
+ Hits        22218    22386     +168     
- Misses      10124    10526     +402     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy merged commit afbfede into dojoengine:main Apr 1, 2024
11 of 12 checks passed
@kariy kariy deleted the fix-test branch April 1, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant