Sozo CLI --version displaying more info #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glihm
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Great work, thank you @fabrobles92!
I've pushed minor fix in the testing that was causing CI to fail (not related to your code directly).
If it's your first contribution to dojo and you are OD eligible, please reach out to me on dojo discord.
|
@glihm Thank you very much for the guidance and the opportunity :) |
kariy
pushed a commit
that referenced
this pull request
Mar 28, 2024
* Creation of fn generate_version that gathers versions of requested tools. * fix: ensure saya test always wait tx to be executed * fix: fmt --------- Co-authored-by: glihm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation of fn generate_version that gathers versions of cairo, scarb, sierra and sozo and rewrite the --version default behavior given by library clap, looking now very similar to the output of scarb --version.
closes #1696
closes DOJ-290