-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sozo] generate JSON manifest #1694
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1694 +/- ##
==========================================
+ Coverage 68.09% 68.26% +0.16%
==========================================
Files 273 274 +1
Lines 29509 29716 +207
==========================================
+ Hits 20095 20286 +191
- Misses 9414 9430 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from few comment, LGTM!
* feat: add support for AbiFormat (path or embed) * fix: add example updated manifests * editor: add custom build commands * fix: remove print and fmt + clippy * add vscode settings to gitignore * fix: ensure pretty formatting of the json * chore: add all .vscode to gitignore * chore: remove vscode tasks * fix: enable PartialEq only for testing when required
Fixes #1665
Fixed DOJ-265
Generates the
json
manifest along with thetoml
. Thejson
manifest has the ABI embedded.@lambda-0x I have tried to have two structs, but it was too heavy. Hopefully this solution is not that ugly to you. :)