Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: delete entity models #1191

Merged
merged 5 commits into from
Nov 21, 2023
Merged

core: delete entity models #1191

merged 5 commits into from
Nov 21, 2023

Conversation

shramee
Copy link
Contributor

@shramee shramee commented Nov 16, 2023

No description provided.

@shramee shramee marked this pull request as draft November 16, 2023 14:50
@shramee shramee marked this pull request as ready for review November 19, 2023 19:51
tarrencev
tarrencev requested changes Nov 20, 2023
View reviewed changes
crates/dojo-core/src/world.cairo Outdated Show resolved Hide resolved
@shramee
Copy link
Contributor Author

shramee commented Nov 21, 2023 •
edited
Loading

Thanks for fixing the contract address!

@tarrencev
Copy link
Contributor

np, it is a bit annoying and we need to automate it

@tarrencev tarrencev merged commit 0fa1b2a into dojoengine:main Nov 21, 2023
9 checks passed
@shramee shramee mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrencev tarrencev tarrencev requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shramee @tarrencev