[Dojo] issue with delete_entity command

[bal7hazar]

I am facing an issue while using commands::delete_entity that leads to not delete my entity and allow the following test to pass:

let mut tile_sk: Query = (ctx.caller_account, col, row).into();
commands::<Tile>::delete_entity(tile_sk);
let tile = commands::<Tile>::entity(tile_sk);

By using the following work around, I succeeded to have my entity to be deleted

let mut tile_sk: Query = (ctx.caller_account, col, row).into();
ctx.world.delete_entity(ctx, 'Tile'.into(), tile_sk);
let tile = commands::<Tile>::entity(tile_sk);  <-- raised an error

[ponderingdemocritus]

@bal7hazar can you confirm this is still an issue

[tarrencev]

@neotheprogramist can you confirm this is resolved with the new indexer logic

[neotheprogramist]

I don't think we addressed this issue while working on the indexer logic.
@bal7hazar Could you provide broader context or some tests so I could check that on the newest dojo version, please?

[bal7hazar]

I did not use it for a while, not sure if it is still an issue, better to close and reopen if needed probably.

[shramee]

This test fails with incorrect post delete energy,

    #[test]
    #[available_gas(30000000)]
    fn test_delete_entity() {
        let (caller, world, actions_) = init();

        let energy_init = Energy { amt: 10, id: 1 };

        set!(world, (energy_init));

        let energy = get!(world, (1), (Energy));
        assert(energy.amt == 10, 'incorrect energy');

        world.delete_entity('RPSType', array![1].span());

        let post_delete_energy = get!(world, (1), (Energy));
        assert(post_delete_energy.amt == 0, 'incorrect post delete energy');
    }

➜  contracts git:(main) ✗ sozo test
running 1 tests
test emojiman::actions::tests::test_delete_entity ... fail (gas usage est.: 6075238)
failures:
   emojiman::actions::tests::test_delete_entity - panicked with [11103201786955740868605512006434910093315610855676006929386402113401 ('incorrect post delete energy'), ].

error: test result: FAILED. 0 passed; 1 failed; 0 ignored

[shramee]

I'm happy to grab this, we need to delete entities...

[ponderingdemocritus]

how did you go with this @shramee ?

[shramee]

This is fixed and merged

[shramee]

#1191