cli/command: remove unused args from ResolveDefaultContext() (step 2) #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
area/context
kind/refactor
thaJeztah
force-pushed
the
context_cleanup_part1
branch
from
298b953 to
7770910
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3510 +/- ##
==========================================
+ Coverage 59.72% 59.77% +0.05%
==========================================
Files 287 287
Lines 24832 24806 -26
==========================================
- Hits 14831 14828 -3
+ Misses 9115 9092 -23
Partials 886 886 |
|
@silvin-lubecki @rumpl ptal |
ndeloof
approved these changes
Apr 8, 2022
thaJeztah
added a commit
to thaJeztah/buildx
that referenced
this pull request
Apr 8, 2022
just double-checking if docker/cli#3510 doesn't break anything. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
commented
Apr 8, 2022
| @@ -31,66 +29,32 @@ type ContextStoreWithDefault struct { | |||
| Resolver DefaultContextResolver | |||
| } | |||
|
|
|||
| // EndpointDefaultResolver is implemented by any EndpointMeta object | |||
| // which wants to be able to populate the store with whatever their default is. | |||
| type EndpointDefaultResolver interface { | |||
There was a problem hiding this comment.
Looks like this is used in buildx (see docker/buildx#1054); let me check how/why and if it's strictly needed
+ xx-go build -ldflags '-X github.com/docker/buildx/version.Version=9e61f69 -X github.com/docker/buildx/version.Revision=9e61f69a5b83c3d6ee5545e488d5ad430c894276 -X github.com/docker/buildx/version.Package=github.com/docker/buildx -w -s' -o /usr/bin/buildx ./cmd/buildx
# github.com/docker/buildx/driver/kubernetes/context
driver/kubernetes/context/load.go:31:7: undefined: command.EndpointDefaultResolver
|
let me move this temporarily back to draft, while we can discuss what to do with these options. |
thaJeztah
force-pushed
the
context_cleanup_part1
branch
from
c735e08 to
13edf41
Compare
thaJeztah
changed the title
thaJeztah
force-pushed
the
context_cleanup_part1
branch
from
13edf41 to
624d62b
Compare
thaJeztah
force-pushed
the
context_cleanup_part1
branch
from
624d62b to
6ea9cba
Compare
thaJeztah
force-pushed
the
context_cleanup_part1
branch
from
6ea9cba to
d358867
Compare
this was added as part of 520be05, but is not used anywhere, so we may as well simplify things a bit. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This was added in 4f14c49, in preparation of 1433e27, but no longer used, so we can remove it. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
context_cleanup_part1
branch
from
d358867 to
13bccd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)