cli/command: remove unused args from ResolveDefaultContext() #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <[email protected]>
This was added in 3126920, and modified in 520be05, but is not used anywhere. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Inlining what it does Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added a commit
to thaJeztah/buildx
that referenced
this pull request
Jul 21, 2022
just double-checking if docker/cli#3715 doesn't break anything. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added a commit
to thaJeztah/buildx
that referenced
this pull request
Jul 21, 2022
just double-checking if docker/cli#3715 doesn't break anything. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added a commit
to thaJeztah/buildx
that referenced
this pull request
Jul 21, 2022
just double-checking if docker/cli#3715 doesn't break anything. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added a commit
to thaJeztah/buildx
that referenced
this pull request
Jul 21, 2022
just double-checking if docker/cli#3715 doesn't break anything. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/context
kind/refactor
|
@crazy-max PTAL; this is a smaller diff than #3510 (we need to look at the remaining parts), but this diff appears to not break Buildx (with some small changes); see docker/buildx#1054 |
thaJeztah
added a commit
to thaJeztah/buildx
that referenced
this pull request
Jul 25, 2022
just double-checking if docker/cli#3715 doesn't break anything. Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
Let me get this one in, as #3510 was already approved, and this is a subset of that PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commits for details
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)