bake: various fixes for composable attributes #2814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
bake-composable-attributes-phase2
branch
from
72a566c to
73f055d
Compare
jsternberg
force-pushed
the
bake-composable-attributes-phase2
branch
from
73f055d to
70c1cad
Compare
jsternberg
force-pushed
the
bake-composable-attributes-phase2
branch
2 times, most recently
from
8eafb54 to
753705d
Compare
jsternberg
force-pushed
the
bake-composable-attributes-phase2
branch
2 times, most recently
from
d03e42f to
4e32acc
Compare
jsternberg
changed the title
jsternberg
force-pushed
the
bake-composable-attributes-phase2
branch
from
4e32acc to
91f0596
Compare
jsternberg
force-pushed
the
bake-composable-attributes-phase2
branch
2 times, most recently
from
e86f8b3 to
e466b5b
Compare
This changes how the composable attributes are implemented and provides various fixes to the first iteration. Cache-from and cache-to now no longer print sensitive values that are automatically added. These automatically added attributes are added when the protobuf is created rather than at the time of parsing so they will no longer be printed. If they are part of the original configuration file, they will still be printed. Empty strings will now be skipped. This was the original behavior and composable attributes removed this functionality accidentally. This functionality is now restored. This also expands the available syntax that works with each of the composable attributes. It is now possible to interleave the csv syntax with the object syntax without any problems. The canonical form is still the object syntax and variables are resolved according to that syntax. Signed-off-by: Jonathan A. Sternberg <[email protected]>
crazy-max
force-pushed
the
bake-composable-attributes-phase2
branch
from
e466b5b to
d0212a9
Compare
|
rebased to fix xx issue |
crazy-max
approved these changes
Dec 11, 2024
crazy-max
reviewed
Dec 11, 2024
| } | ||
|
|
||
| cache-from = [ | ||
| "type=gha", |
There was a problem hiding this comment.
small nit, In https://github.com/docker/buildx/pull/2827/files#diff-095bae3e0563ad1f84bf1ca114f4687cc22db9bbbdd54299055015838038f235R84 I specifically sets token attribute in the definition to make sure it's being printed as intended if you want to add this new case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how the composable attributes are implemented and provides
various fixes to the first iteration.
Cache-from and cache-to now no longer print sensitive values that are
automatically added. These automatically added attributes are added when
the protobuf is created rather than at the time of parsing so they will
no longer be printed. If they are part of the original configuration
file, they will still be printed.
Empty strings will now be skipped. This was the original behavior and
composable attributes removed this functionality accidentally. This
functionality is now restored.
This also expands the available syntax that works with each of the
composable attributes. It is now possible to interleave the csv syntax
with the object syntax without any problems. The canonical form is still
the object syntax and variables are resolved according to that syntax.
Fixes #2823.
Fixes #2822.
Replaces #2832.
Replaces #2833.