bake: cache-from/cache-to options no longer print sensitive values #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
bake-cache-sensitive-attrs
branch
5 times, most recently
from
7ea690b
to
c15110e
Compare
This refactors how the cache-from/cache-to composable attributes work so they no longer print sensitive values that are automatically added. This also expands the available syntax that works with the cache options. It is now possible to interleave the csv syntax with the object syntax without any problems. The canonical form is still the object syntax and variables are resolved according to that syntax. `cache-from` and `cache-to` now correctly ignore empty string inputs so these can be used with variables. Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
bake-cache-sensitive-attrs
branch
from
c15110e
to
7a8ebdc
Compare
crazy-max
reviewed
Dec 3, 2024
| @@ -674,7 +674,7 @@ func TestHCLAttrsCapsuleTypeVars(t *testing.T) { | |||
| output = [ "type=oci,dest=../${foo}.tar" ] | |||
|
|
|||
| secret = [ | |||
| { id = target.app.output[0].type, src = "/local/secret" }, | |||
| { id = target.app.output[0].type, src = "/${target.app.cache-from[1].type}/secret" }, | |||
There was a problem hiding this comment.
@dvdksn I'm not sure we have examples showing how to reference attributes. I think the example with cache-to = [ target.app.cache-from[0] ] is a good one.
There was a problem hiding this comment.
We have a simpler example: https://docs.docker.com/build/bake/inheritance/#reusing-single-attributes-from-targets
We don't show interpolation though, maybe we should
crazy-max
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors how the cache-from/cache-to composable attributes work so they no longer print sensitive values that are automatically added.
This also expands the available syntax that works with the cache options. It is now possible to interleave the csv syntax with the object syntax without any problems. The canonical form is still the object syntax and variables are resolved according to that syntax.
cache-fromandcache-tonow correctly ignore empty string inputs so these can be used with variables.Fixes #2823.
Partial fix for #2822.