-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring elm
branch up-to-date with master
to fix ihp-new for elm
#40
Conversation
feat: add devenv support
Co-authored-by: Lars Lillo Ulvestad <[email protected]>
Co-authored-by: Lars Lillo Ulvestad <[email protected]>
Co-authored-by: Lars Lillo Ulvestad <[email protected]>
the old version wasn't compatible with packages.system.default outputs in flakes
…flake Use flake-parts module
nix should lock the inputs itself on first call
…remove-lock-file Remove lock file
Without the lockfile ihp-new crashes when creating a new project
* Add more defaults an docs to flake.nix * SMTP config for local development. * Code review fixes * Change app name to `qa` * Remove mailhog from packages * Add SMTP_ENCRYPTION * envName * Update flake.nix * Update flake.nix * Apply suggestions from code review Co-authored-by: Marc Scholten <[email protected]> * Apply suggestions from code review --------- Co-authored-by: Marc Scholten <[email protected]>
…nduced#32) * Add config with placeholder for logging to AWS CloudWatch * Comment out services.vector
* Add IHP_SESSION_SECRET placeholder * Add comment * Improve comment
Test and deploy using Github Actions
Disk space issue workaround
I have realized that elam not working might be some functionality of former start script which was not migrated to devenv setup. I will try to dig in later |
Thanks 👍 I think the # Custom configuration that will start with `devenv up`
devenv.shells.default = {
# Start Mailhog on local development to catch outgoing emails
# services.mailhog.enable = true;
languages.elm.enable = true;
processes = {
frontend.exec = "parcel watch elm/index.js --out-dir static/elm";
};
}; |
I have added npm build command to @mpscholten do you want me to add |
Best option seems to be both: we merge the current PR as is, so elm is working again. And I'd be happy to merge a second PR that improves the npm workflow. Ideally removing the need for a manual |
There is an issue with
ihp-new --elm myProject
command tracked as issue here: digitallyinduced/ihp#1955 .This pr merges
master
branch intoelm
. There were merge conflicts instart
anddefault.nix
files which were resolved in favor ofmaster
version.Merged version were tested by running edited local copy of
ihp-new
bash script which pointed to my version of boilerplate git repo. This successfully created a project files.start
script successfully started dev server, web based ide and dummy version of application itself. Based on initial webapp msg elm is not working but that is a different issue.