-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
eeb86b4
commit eebbda8
Showing
2 changed files
with
10 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,9 @@ | ||
let | ||
ihp = builtins.fetchGit { | ||
url = "https://github.com/digitallyinduced/ihp.git"; | ||
ref = "refs/tags/v1.0.1"; | ||
}; | ||
haskellEnv = import "${ihp}/NixSupport/default.nix" { | ||
ihp = ihp; | ||
haskellDeps = (import ./devenv.nix { pkgs = {}; inputs = {}; config = {}; }).ihp.haskellPackages; | ||
otherDeps = pkgs: (import ./devenv.nix { inherit pkgs; inputs = {}; config = {}; }).packages; | ||
projectPath = ./.; | ||
}; | ||
in | ||
haskellEnv | ||
# For backwards compatibility using flake.nix | ||
(import | ||
( | ||
fetchTarball { | ||
url = "https://github.com/edolstra/flake-compat/archive/12c64ca55c1014cdc1b16ed5a804aa8576601ff2.tar.gz"; | ||
sha256 = "0jm6nzb83wa6ai17ly9fzpqc40wg1viib8klq8lby54agpl213w5"; | ||
} | ||
) | ||
{ src = ./.; }).defaultNix |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eebbda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mpscholten this broke new IHP projects for us on macOS and Codespaces. Is this a mistake? Or is something not configured right on our end to support this?
eebbda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share the error message? This change is in preparation for the upcoming IHP v1.1.0 release
eebbda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things seem to go wrong, including
direnv allow
not working:And, when trying to run
nix-shell
:eebbda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be caused by a missing
flake.lock
. Just pushed this via 177a78a Nowihp-new test
work again locallyeebbda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try it out, thank you!
eebbda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still getting this when trying to run it in Codespaces (the old default.nix without flake still works perfectly). And this version does appear to work in macOS. Any ideas?
eebbda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, I think we have to retool our
postCreateCommand
script. I'll play with it and get back to you.eebbda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let me know in case I can help in any way
eebbda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Marc! Still having the issue above in Codespaces. In a plain Ubuntu installation using Nix directly, the server compiles all the way to
Main
but then we never get "Server started". The Dev server runs, but the actual application server gets stuck on the compiling screen. This repo, which is the boilerplate from 2 weeks ago, works fine.eebbda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I know that's not much of a bug report! But it didn't give me much more information. Here's how it gets stuck:
eebbda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Can you it with the env var
DEBUG=1
set? Then the terminal will output lots of debug info. Could you share that debug info here?eebbda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eebbda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is wrong with postgres. Can you run
make postgres
to start the postgres server manually? This will likely output the error postgres receives on startupeebbda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered if it was something about Postgres. Weird... is it not being installed for some reason?
eebbda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share what is in
.envrc
?