Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: article about error messages (cross-agency cooperation) #2096

Merged
merged 32 commits into from
Aug 6, 2024

Conversation

mrosvik
Copy link
Member

@mrosvik mrosvik commented Jun 4, 2024

Resolves #2093

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Preview deployments for this pull request:

🖥 Storefront 6. Aug 2024 - 07:52 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@mrosvik mrosvik changed the title Article about error messages (Cross-agency cooperation) docs: article about error messages (cross-agency cooperation) Jun 28, 2024
@mrosvik mrosvik marked this pull request as ready for review June 28, 2024 10:42
@mrosvik mrosvik requested review from mimarz and Barsnes as code owners June 28, 2024 10:42
@mrosvik mrosvik mentioned this pull request Jun 28, 2024
Copy link
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Har retta på litt skrivefeil, men ser også at lister variera på om dei begynner med stor eller liten bokstav. Er dette bestemt med om lista ligger bak kolon, eller ikkje?

apps/storefront/pages/monstre/feilmeldinger.mdx Outdated Show resolved Hide resolved
apps/storefront/pages/monstre/feilmeldinger.mdx Outdated Show resolved Hide resolved
apps/storefront/pages/monstre/feilmeldinger.mdx Outdated Show resolved Hide resolved
apps/storefront/pages/monstre/feilmeldinger.mdx Outdated Show resolved Hide resolved
apps/storefront/pages/monstre/feilmeldinger.mdx Outdated Show resolved Hide resolved
apps/storefront/pages/monstre/feilmeldinger.mdx Outdated Show resolved Hide resolved
apps/storefront/pages/monstre/feilmeldinger.mdx Outdated Show resolved Hide resolved
Copy link

changeset-bot bot commented Aug 6, 2024

⚠️ No Changeset found

Latest commit: 233f1cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrosvik
Copy link
Member Author

mrosvik commented Aug 6, 2024

Har retta på litt skrivefeil, men ser også at lister variera på om dei begynner med stor eller liten bokstav. Er dette bestemt med om lista ligger bak kolon, eller ikkje?

Bra funn @Barsnes ! ⭐️ Ja, det er noen regler, @Ildest har skrevet om det i liste-komponenten.

Når hvert punkt er en fortsettelse av innledningen til punktlisten, som er mest vanlig,
bruker vi
·      liten forbokstav i punktene
·      ikke kolon etter innledningen
·      ikke punktum eller komma til slutt på hvert punkt 


Når punktene er hele setninger, bruker vi stor forbokstav i det første ordet og punktum til slutt på hvert punkt.

@mrosvik mrosvik requested a review from Barsnes August 6, 2024 05:52
Copy link
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mrosvik mrosvik merged commit 6160469 into main Aug 6, 2024
3 checks passed
Barsnes added a commit that referenced this pull request Aug 6, 2024
Resolves #2093

---------

Co-authored-by: Lasse Karlsen <[email protected]>
Co-authored-by: Tobias Barsnes <[email protected]>
Barsnes added a commit that referenced this pull request Aug 6, 2024
Resolves #2093

---------

Co-authored-by: Lasse Karlsen <[email protected]>
Co-authored-by: Tobias Barsnes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants