-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 修复一系列Label插件问题 #1969
Merged
Merged
fix: 修复一系列Label插件问题 #1969
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
39e7bc9
fix(extension/label): 修复文本框固定展示白底和hover后内容偏移问题
3391c95
fix(extension/label): 修复Label框单击后无法拖动问题
7bf13e5
feat(extension/label): label支持删除
471feca
fix(extension/label): 是否执行删除逻辑增加当前画布编辑状态的判断
929e67b
fix(extension/label): 修改边框样式
0f8bf72
fix(extension/style): 修复拖拽面板被label遮挡问题
48060a2
fix(core): 修复使用label情况下双击节点会让节点进入文本编辑态问题
0a7275c
fix: 修复点击其他label时当前label状态不更新问题
cd9bfb6
fix: 在 Label 插件中需要使用 getData 中的 type 字段,但类型未定义,打包会报错
boyongjiong 71c4b7e
style(extension/labable): 解决.lf-label-overlay的重复样式
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,6 +64,7 @@ export class LabelModel { | |
id: this.id, | ||
x: this.x, | ||
y: this.y, | ||
type: 'label', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 增加了该 type 标识,但 LabelData 类型和 LabelConfig 类型中都没有改属性,所以增加 core 包类型定义,解决打包报错的问题 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let me cc |
||
content: this.content, | ||
value: this.value, | ||
rotate: this.rotate, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see see