fix: 修复一系列Label插件问题 #1969
Merged
fix: 修复一系列Label插件问题 #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 21, 2024 14:25
|
boyongjiong
reviewed
Nov 22, 2024
| @@ -32,13 +32,13 @@ | |||
| } | |||
|
|
|||
| &-editing { | |||
| border: 2px solid #275dc5; | |||
| outline: 2px solid #275dc5; | |||
|
这个 PR，我本地删除依赖，重新 install，build 会失败，你周一看下你那边有没有问题，如果有定位下原因处理一下哈 |
boyongjiong
reviewed
Nov 25, 2024
| @@ -64,6 +64,7 @@ export class LabelModel { | |||
| id: this.id, | |||
| x: this.x, | |||
| y: this.y, | |||
| type: 'label', | |||
There was a problem hiding this comment.
增加了该 type 标识，但 LabelData 类型和 LabelConfig 类型中都没有改属性，所以增加 core 包类型定义，解决打包报错的问题
boyongjiong
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat:
fix:
relate issues #1966 #1910 #1909