-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality and test the happy path #3
Conversation
@peterpeterparker can you take a look? I still had to change the configs a bit to have them working in my first test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx
@peterpeterparker thanks for the review. I realized that the test is not testing the flow properly. I need to change the test. |
@lmuntaner no worries, I did not reviewed the test itself anyway, only the configuration 😉 |
Thanks, I forgot to return the promise. That's why it was passing even though. it shouldn't. The only problem was in the mocked data sent in the post message. Nothing major. |
Motivation
Create a first real test working before moving to more complex tests and before refactoring the code to make it look nice.
I realized there were also issues with the spec files that didn't have prettier or lint working.
Changes
tsc
before running tests.requestVerifiablePresentation
. DO NOT REVIEW THIS YET. This is working functionality but it will be refactored a lot.Tests
requestVerifiablePresentation
.