Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include test files to Lint #2

Closed
wants to merge 1 commit into from
Closed

Include test files to Lint #2

wants to merge 1 commit into from

Conversation

lmuntaner
Copy link
Collaborator

Motivation

The test files were not linted.

Changes

  • Remove test files from ignore pattern in eslint config.
  • Create a tsconfig only for test.
  • Run tsc before running tests.
  • Install @types/jest.

Tests

Only test changes

lmuntaner
lmuntaner commented Apr 24, 2024
View reviewed changes
js-library/package-lock.json
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here were pending from before. I forgot to run npm i after movint from jest to vitest.

@lmuntaner lmuntaner marked this pull request as draft April 24, 2024 07:56
@lmuntaner
Copy link
Collaborator Author

Closing in favor of #3

@lmuntaner lmuntaner closed this Apr 24, 2024
@lmuntaner lmuntaner deleted the lm-add-lint-to-tests branch April 24, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lmuntaner