Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cmc): Fixed a comment in CMC automatic refund. #3634

Merged
merged 2 commits into from
Jan 27, 2025
Merged

docs(cmc): Fixed a comment in CMC automatic refund. #3634

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33abcf8
Fixed a comment in CMC automatic refund.
daniel-wong-dfinity-org Jan 27, 2025
964ca4f
Nano comment fix.
daniel-wong-dfinity-org Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions rs/nns/cmc/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1885,8 +1885,9 @@ async fn issue_automatic_refund_if_memo_not_offerred(
})
}

// There is no (known) way to reach this case, since we already
// verified that memo is in MEANINGFUL_MEMOS.
// There is no (known) way to reach this case, since an check
daniel-wong-dfinity-org marked this conversation as resolved.
Show resolved Hide resolved
// earlier in this function ensures by this point, memo is not one
// of the special meaningful values.
NotifiedCreateCanister(_) | NotifiedMint(_) | NotifiedTopUp(_) => {
Err(NotifyError::InvalidTransaction(format!(
"Block has already been processed: {:?}",
Expand Down
Loading