Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cmc): Fixed a comment in CMC automatic refund. #3634

Merged

Conversation

daniel-wong-dfinity-org
Copy link
Contributor

This is per feedback from Andrew Lee.

@daniel-wong-dfinity-org daniel-wong-dfinity-org marked this pull request as ready for review January 27, 2025 15:06
@daniel-wong-dfinity-org daniel-wong-dfinity-org requested a review from a team as a code owner January 27, 2025 15:06
@github-actions github-actions bot added the docs label Jan 27, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).

To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:

  1. Done.

  2. No canister behavior changes.

@daniel-wong-dfinity-org
Copy link
Contributor Author

daniel-wong-dfinity-org commented Jan 27, 2025

Oops. Where I replied "Done." to the nag bot, I should have said "No canister behavior changes.". I was was confused about which browser tab I was looking at.

rs/nns/cmc/src/main.rs Outdated Show resolved Hide resolved
Co-authored-by: Arshavir Ter-Gabrielyan <[email protected]>
@daniel-wong-dfinity-org daniel-wong-dfinity-org added this pull request to the merge queue Jan 27, 2025
Merged via the queue into master with commit 8f4c5bb Jan 27, 2025
25 checks passed
@daniel-wong-dfinity-org daniel-wong-dfinity-org deleted the fix-comment-in-cmc-automatic-refund-daniel-wong branch January 27, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants