refactor(crypto): CRP-2596 rename VetKdArgs::encryption_key to encryption_public_key #2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspreiss
changed the title
fspreiss
referenced
this pull request
Nov 25, 2024
Introduce a `VetKdProtocol` trait and implement it for `CryptoReturningOk`. The trait is designed so that underneath we can implement the cryptographic protocol specified in the π<sub>vetbls-agg2</sub> scheme specified in section 5.3 of the [vetKeys research paper](https://eprint.iacr.org/2023/616.pdf), in its _optimistic_ variant, where the meaning of optimistic is described in section 9 of the research paper. The π<sub>vetbls-agg2</sub> scheme is implemented in [ic-crypto-internal-bls12-381-vetkd](https://github.com/dfinity/ic/blob/master/rs/crypto/internal/crypto_lib/bls12_381/vetkd/src/lib.rs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
VetKdArgs::encryption_keytoVetKdArgs::encryption_public_keyto avoid confusions as to whether this is the private or the public part of an asymmetric encryption key pair and thus to make clear that this is not sensitive information.