feat: CRP-2611 Introduce new context type for VetKD requests #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eichhorl
changed the title
eichhorl
changed the title
eichhorl
changed the title
eichhorl
commented
Nov 19, 2024
rs/replicated_state/src/metadata_state/subnet_call_context_manager.rs
Outdated
Show resolved
Hide resolved
maksymar
previously approved these changes
Nov 19, 2024
fspreiss
previously approved these changes
Nov 19, 2024
rs/replicated_state/src/metadata_state/subnet_call_context_manager.rs
Outdated
Show resolved
Hide resolved
eichhorl
requested review from
alin-at-dfinity,
Sawchord,
maksymar and
fspreiss
fspreiss
approved these changes
Nov 22, 2024
maksymar
approved these changes
Nov 22, 2024
Sawchord
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We extend the existing
SignWithThresholdContextby adding anotherThresholdArgumentsvariant of typeVetKdArguments. Contexts of this type cannot be created yet.In addition, the compiler forces us to define a cycles cost for vet KD requests. For now we choose the same cost as for tEcdsa and tSchnorr, but this may be refined further at a later stage.
There are some parts in consensus where we only want to handle tSchnorr and tEcdsa contexts (as they rely on IDKG), but ignore vet KD contexts (as they rely on NiDKG). For that reason we add a new type
IDkgSignWithThresholdContextwhich wraps the reference to aSignWithThresholdContext, but only if that context may be handled by IDKG. Functions in the IDKG component are then changed to accept the new type.