-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added function to compare chunks #841
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
19b3acc
chunk.go: add Equals()
ethaniccc 403c0d4
simplify
ethaniccc 96dfd1f
Merge pull request #1 from df-mc/master
ethaniccc 3ac37c1
Don't compare chunks if height map needs to be re-calculated
ethaniccc a665196
go fmt
7db49bc
don't compare recalculateHeightMap
ethaniccc 4381e5f
only calculate heightMap if both chunks don't need heightMap recalcul…
ethaniccc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,5 +1,7 @@ | ||||||
package chunk | ||||||
|
||||||
import "slices" | ||||||
|
||||||
// SubChunk is a cube of blocks located in a chunk. It has a size of 16x16x16 blocks and forms part of a stack | ||||||
// that forms a Chunk. | ||||||
type SubChunk struct { | ||||||
|
@@ -14,6 +16,25 @@ func NewSubChunk(air uint32) *SubChunk { | |||||
return &SubChunk{air: air} | ||||||
} | ||||||
|
||||||
// Equals returns if the sub chunk passed is equal to the current one. | ||||||
func (sub *SubChunk) Equals(s *SubChunk) bool { | ||||||
if s.air != sub.air || !slices.Equal(s.blockLight, sub.blockLight) || | ||||||
!slices.Equal(s.skyLight, sub.skyLight) || len(s.storages) != len(sub.storages) { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
return false | ||||||
} | ||||||
|
||||||
for i := 0; i < len(s.storages); i++ { | ||||||
s1 := s.storages[i] | ||||||
s2 := sub.storages[i] | ||||||
|
||||||
if !s1.Equal(s2) { | ||||||
return false | ||||||
} | ||||||
} | ||||||
|
||||||
return true | ||||||
} | ||||||
|
||||||
// Empty checks if the SubChunk is considered empty. This is the case if the SubChunk has 0 block storages or if it has | ||||||
// a single one that is completely filled with air. | ||||||
func (sub *SubChunk) Empty() bool { | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.