Added function to compare chunks #841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sandertv
reviewed
Jan 10, 2024
|
👍 |
|
bump |
rebump |
|
bumpy |
|
can we merge this? I'd like to be able to get rid of my dragonfly fork I'm currently using |
|
@ethaniccc :V |
RestartFU
suggested changes
Mar 4, 2024
| @@ -14,6 +16,25 @@ func NewSubChunk(air uint32) *SubChunk { | |||
| return &SubChunk{air: air} | |||
| } | |||
|
|
|||
| // Equals returns if the sub chunk passed is equal to the current one. | |||
| func (sub *SubChunk) Equals(s *SubChunk) bool { | |||
| if s.air != sub.air || !slices.Equal(s.blockLight, sub.blockLight) || | |||
There was a problem hiding this comment.
Suggested change
| if s.air != sub.air || !slices.Equal(s.blockLight, sub.blockLight) || | |
| if s.air != sub.air || |
| // Equals returns if the sub chunk passed is equal to the current one. | ||
| func (sub *SubChunk) Equals(s *SubChunk) bool { | ||
| if s.air != sub.air || !slices.Equal(s.blockLight, sub.blockLight) || | ||
| !slices.Equal(s.skyLight, sub.skyLight) || len(s.storages) != len(sub.storages) { |
There was a problem hiding this comment.
Suggested change
| !slices.Equal(s.skyLight, sub.skyLight) || len(s.storages) != len(sub.storages) { | |
| len(s.storages) != len(sub.storages) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for two chunks with two different pointers to still be compared for equality.
(pls merge so I don't have to update oomph's fork 🙏)