Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 온보딩 이미지 lazy-loading 제거 #447

Merged
merged 8 commits into from
Oct 10, 2024
Merged

chore: 온보딩 이미지 lazy-loading 제거 #447

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b8973d6
fix: 빌드 에러 수정
wokbjso Sep 13, 2024
0f3826b
Merge branch 'main' of https://github.com/depromeet/15th-Team2-Web
wokbjso Sep 13, 2024
2a5ed6e
Merge branch 'main' of https://github.com/depromeet/15th-Team2-Web
wokbjso Sep 13, 2024
346cec5
Merge branch 'main' of https://github.com/depromeet/15th-Team2-Web
wokbjso Sep 19, 2024
db8edde
Merge branch 'main' of https://github.com/depromeet/15th-Team2-Web
wokbjso Oct 8, 2024
001bc0a
Merge branch 'main' of https://github.com/depromeet/15th-Team2-Web
wokbjso Oct 10, 2024
bd87f8f
chore: 온보딩 이미지 lazy-loading 제거
wokbjso Oct 10, 2024
542033b
chore: 코드 리뷰 반영
wokbjso Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions features/on-boarding/components/molecules/steps.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export function Steps({ current }: StepsProps) {
alt="온보딩 이미지"
fill
style={{ objectFit: 'contain' }}
priority
Copy link
Member

@Jungjjeong Jungjjeong Oct 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우선순위를 최상위로 높이는 방법 보다는 lazy='eager' 속성을 적용해야 할 것 같아요.
현재 이미지가 늦게 뜨는 이유는, 화면에 보여지지 않는 영역의 이미지가 로딩이 지연되는 원인이 클 것 같습니다.

https://nextjs.org/docs/pages/api-reference/components/image

/>
</div>
</div>
Expand Down
Loading