chore: 온보딩 이미지 lazy-loading 제거 #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wokbjso
requested review from
hjy0951,
Jungjjeong and
summermong
as code owners
king2dwellsang
added
Approved 🆗
Jungjjeong
reviewed
Oct 10, 2024
| @@ -41,6 +41,7 @@ export function Steps({ current }: StepsProps) { | |||
| alt="온보딩 이미지" | |||
| fill | |||
| style={{ objectFit: 'contain' }} | |||
| priority | |||
There was a problem hiding this comment.
우선순위를 최상위로 높이는 방법 보다는 lazy='eager' 속성을 적용해야 할 것 같아요.
현재 이미지가 늦게 뜨는 이유는, 화면에 보여지지 않는 영역의 이미지가 로딩이 지연되는 원인이 클 것 같습니다.
https://nextjs.org/docs/pages/api-reference/components/image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 어떤 문제가 발생했나요?
🎉 어떻게 해결했나요?
📷 이미지 첨부 (Option)