Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10-10CG] Update facility address formatting #33808

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

coope93
Copy link
Contributor

@coope93 coope93 commented Dec 30, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

If the folder you changed contains a manifest.json, search for its entryName in the content-build registry.json (the entryName there will match).

If an entry for this folder exists in content-build and you are:

  1. Deleting a folder:

    1. First search vets-website for all instances of the entryName in your manifest.json and remove them in a separate PR. Look particularly for references in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js. If you do not do this, other applications will break!
      • Add the link to your merged vets-website PR here
    2. Then, Delete the application entry in registry.json and merge that PR before this one
      • Add the link to your merged content-build PR here
  2. Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Updated the address formatting on the facility list and facility confirmation page to not have a comma after the state. This change makes it consistent with VA address formatting standards.
  • The date is formatted in the fetchFacilities function, so the formatted date is available anywhere we use the date returned on the facility object (we currently display it on the facilities list on the search page, the facility confirmation page, and the form review page in the facility section).
  • 1010 Health Apps
  • This work is behind the caregiver_use_facilities_API toggle

Related issue(s)

Testing done

  • Updated unit tests

Screenshots

Before After
Screenshot 2024-12-30 at 4 42 31 PM Screenshot 2024-12-30 at 4 41 22 PM

What areas of the site does it impact?

10-10CG

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@coope93 coope93 marked this pull request as ready for review December 31, 2024 11:56
@coope93 coope93 requested review from a team as code owners December 31, 2024 11:56
@coope93 coope93 self-assigned this Dec 31, 2024
@coope93 coope93 merged commit 75a20fa into main Dec 31, 2024
75 checks passed
@coope93 coope93 deleted the 1010cg-format-facility-address branch December 31, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants