Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10-10CG] Update Facility Confirmation Page #33807

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

coope93
Copy link
Contributor

@coope93 coope93 commented Dec 30, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

If the folder you changed contains a manifest.json, search for its entryName in the content-build registry.json (the entryName there will match).

If an entry for this folder exists in content-build and you are:

  1. Deleting a folder:

    1. First search vets-website for all instances of the entryName in your manifest.json and remove them in a separate PR. Look particularly for references in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js. If you do not do this, other applications will break!
      • Add the link to your merged vets-website PR here
    2. Then, Delete the application entry in registry.json and merge that PR before this one
      • Add the link to your merged content-build PR here
  2. Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Updated the 10-10CG Facility Confirmation screen per staging review and research feedback results.
  • **Note: I noticed we have a comma after the state in the address display. This is due to formatting that we do in the fetch call, and I have a separate branch that I will open a PR for to fix it. I wanted to keep it separate. PR here
  • 1010 Health Apps
  • This work is behind the caregiver_use_facilities_API toggle

Related issue(s)

Testing done

  • Updated unit tests to match new design and refactored them a bit

Screenshots

Before After
Mobile Screenshot 2024-12-30 at 4 14 02 PM Screenshot 2024-12-30 at 4 17 46 PM
Desktop Screenshot 2024-12-30 at 4 13 51 PM Screenshot 2024-12-30 at 4 11 09 PM

What areas of the site does it impact?

10-10CG

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@@ -103,65 +89,23 @@ describe('CG <FacilityConfirmation>', () => {
});
});

it('renders selected facility description text', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and removed this test since it wasn't really adding value.


const selectors = () => ({
selectedFacility: {
name: getByText(new RegExp(selectedFacility.name)),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced these with selectors in the specs to simplify these tests a bit.

@coope93 coope93 marked this pull request as ready for review December 30, 2024 21:37
@coope93 coope93 requested review from a team as code owners December 30, 2024 21:37
Copy link
Contributor

@longmd longmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this update! 🚀

@coope93 coope93 merged commit 909de0f into main Dec 31, 2024
75 checks passed
@coope93 coope93 deleted the 99040-facility-confirmation-ui-changes branch December 31, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants