Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

65089 post toxic exposure launch cleanup #33739

Merged
merged 2 commits into from
Jan 6, 2025
Merged

65089 post toxic exposure launch cleanup #33739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10729cc
65089 post toxic exposure launch cleanup
christinec-fftc Dec 20, 2024
cd6d4ce
Merge branch 'main' into dbex/65089-TE-cleanup
christinec-fftc Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/applications/disability-benefits/all-claims/components/CustomReviewTopContent.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from 'react';

Check warning on line 1 in src/applications/disability-benefits/all-claims/components/CustomReviewTopContent.jsx

View workflow job for this annotation

GitHub Actions / App Isolation Annotations

Staged Continuous Deployment App Isolation Conflict 

*WARNING* This PR contains changes related to an application that is currently not isolated.
                
 As of Feb 3, 2025 deployment may no longer be possible for apps that are not isolated.
                
 Please isolate this app from other directories in 'src/applications' to prevent future deployment issues.
                
 More information on your app's status can be seen here: https://department-of-veterans-affairs.github.io/veteran-facing-services-tools/frontend-support-dashboard/cross-app-import-report
                
 Please reach out to Frontend Platform Support with any questions.
import PropTypes from 'prop-types';
import { connect } from 'react-redux';
import { Link } from 'react-router';
Expand All @@ -9,6 +9,7 @@
function CustomReviewTopContent({ formData }) {
const [isVisible, setIsVisible] = useState(true);

// TODO: this alert can be removed 1 year post-launch which is 11/18/2025
if (
formData?.startedFormVersion !== '2019' ||
!isClaimingNew(formData) ||
Expand Down
14 changes: 4 additions & 10 deletions src/applications/disability-benefits/all-claims/content/toxicExposure.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';

Check warning on line 1 in src/applications/disability-benefits/all-claims/content/toxicExposure.jsx

View workflow job for this annotation

GitHub Actions / App Isolation Annotations

Staged Continuous Deployment App Isolation Conflict 

*WARNING* This PR contains changes related to an application that is currently not isolated.
                
 As of Feb 3, 2025 deployment may no longer be possible for apps that are not isolated.
                
 Please isolate this app from other directories in 'src/applications' to prevent future deployment issues.
                
 More information on your app's status can be seen here: https://department-of-veterans-affairs.github.io/veteran-facing-services-tools/frontend-support-dashboard/cross-app-import-report
                
 Please reach out to Frontend Platform Support with any questions.
import {
capitalizeEachWord,
formSubtitle,
Expand Down Expand Up @@ -122,24 +122,18 @@
/* ---------- utils ---------- */
/**
* Checks if the toxic exposure pages should be displayed using the following criteria
* 1. 'startedFormVersion' has 2019 or 2022
* 2. the claim has a claim type of new
* 3. claiming at least one new disability
* 1. the claim has a claim type of new
* 2. claiming at least one new disability
*
* @returns true if all criteria are met, false otherwise
*/
export function showToxicExposurePages(formData) {
return (
(formData?.startedFormVersion === '2019' ||
formData?.startedFormVersion === '2022') &&
isClaimingNew(formData) &&
formData?.newDisabilities?.length > 0
);
return isClaimingNew(formData) && formData?.newDisabilities?.length > 0;
}

/**
* Checks if
* 1. TE pages should be showing at all
* 1. TE pages should be showing
* 2. at least one checkbox on the TE conditions page is selected that is not 'none'
*
* @param {object} formData
Expand Down
Loading
Loading