Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

65089 post toxic exposure launch cleanup #33739

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

christinec-fftc
Copy link
Contributor

@christinec-fftc christinec-fftc commented Dec 20, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Any logic that was preventing toxic exposure pages from displaying is removed
  • Any unit or e2e tests referencing this logic is removed

flipper removal in #99346

Related issue(s)

department-of-veterans-affairs/va.gov-team#65089

Testing done

  • Manually verified 526 form with toxic exposure is working as expected
  • Updated unit and e2e tests accordingly

Screenshots

n/a. no visual changes

What areas of the site does it impact?

526ez

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@christinec-fftc christinec-fftc added the disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) label Dec 20, 2024
Copy link
Contributor

@tommasina-va tommasina-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! LGTM 👏🏻

Copy link
Contributor

@sethdarragile6 sethdarragile6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christinec-fftc christinec-fftc marked this pull request as ready for review January 6, 2025 16:37
@christinec-fftc christinec-fftc requested review from a team as code owners January 6, 2025 16:37
@christinec-fftc christinec-fftc merged commit 5c82128 into main Jan 6, 2025
80 checks passed
@christinec-fftc christinec-fftc deleted the dbex/65089-TE-cleanup branch January 6, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toxic Exposure: Toggle clean up in FE
4 participants