Add character limits for Appoint a Representative

src/applications/representative-appoint/pages/claimant/claimantContactMailing.js

@@ -1,4 +1,4 @@
 import React from 'react';
 
 import {
   addressSchema,
@@ -28,8 +28,31 @@
   type: 'object',
   properties: {
     profileNotUpdatedNote: { type: 'object', properties: {} },
-    homeAddress: addressSchema({
-      omit: ['street3'],
-    }),
+    homeAddress: {
+      ...addressSchema({ omit: ['street3'] }),
+      properties: {
+        ...addressSchema({ omit: ['street3'] }).properties,
+        street: {
+          type: 'string',
+          maxLength: 30,
+        },
+        street2: {
+          type: 'string',
+          maxLength: 5,
+        },
+        city: {
+          type: 'string',
+          maxLength: 18,
+        },
+        state: {
+          type: 'string',
+          maxLength: 2,
+        },
+        postalCode: {
+          type: 'string',
+          maxLength: 9,
+        },
+      },
+    },
   },
 };

src/applications/representative-appoint/pages/claimant/claimantContactPhoneEmail.js

@@ -1,4 +1,4 @@
 import React from 'react';
 
 import {
   phoneUI,
@@ -30,6 +30,10 @@
     titleSchema,
     profileNotUpdatedNote: { type: 'object', properties: {} },
     applicantPhone: phoneSchema,
-    applicantEmail: emailSchema,
+    applicantEmail: {
+      ...emailSchema,
+      type: 'string',
+      maxLength: 31,
+    },
   },
 };

src/applications/representative-appoint/pages/claimant/claimantPersonalInformation.js

@@ -1,4 +1,4 @@
 import React from 'react';
 import { cloneDeep } from 'lodash';
 
 import {
@@ -33,7 +33,24 @@
   properties: {
     titleSchema,
     profileNotUpdatedNote: { type: 'object', properties: {} },
-    applicantName: fullNameSchema,
+    applicantName: {
+      ...fullNameSchema,
+      properties: {
+        ...fullNameSchema.properties,
+        first: {
+          type: 'string',
+          maxLength: 12,
+        },
+        middle: {
+          type: 'string',
+          maxLength: 1,
+        },
+        last: {
+          type: 'string',
+          maxLength: 18,
+        },
+      },
+    },
     applicantDOB: dateOfBirthSchema,
   },
 };

src/applications/representative-appoint/pages/claimant/claimantRelationship.js

@@ -1,4 +1,4 @@
 import React from 'react';
 import {
   radioSchema,
   radioUI,
@@ -32,6 +32,7 @@
       expandUnder: 'claimantRelationship',
       expandUnderCondition: 'RELATIONSHIP_NOT_LISTED',
       expandedContentFocus: true,
+      maxLength: 42,
     },
     'ui:errorMessages': {
       required: `Please enter your relationship to the Veteran`,
@@ -59,6 +60,6 @@
   required: ['claimantRelationship'],
   properties: {
     claimantRelationship: radioSchema(Object.keys(claimantRelationships)),
-    relationshipNotListed: { type: 'string' },
+    relationshipNotListed: { type: 'string', maxLength: 42 },
   },
 };

src/applications/representative-appoint/pages/veteran/veteranContactMailing.js

@@ -1,4 +1,4 @@
 import React from 'react';
 
 import {
   addressSchema,
@@ -28,8 +28,31 @@
   properties: {
     titleSchema,
     profileNotUpdatedNote: { type: 'object', properties: {} },
-    veteranHomeAddress: addressSchema({
-      omit: ['street3'],
-    }),
+    veteranHomeAddress: {
+      ...addressSchema({ omit: ['street3'] }),
+      properties: {
+        ...addressSchema({ omit: ['street3'] }).properties,
+        street: {
+          type: 'string',
+          maxLength: 30,
+        },
+        street2: {
+          type: 'string',
+          maxLength: 5,
+        },
+        city: {
+          type: 'string',
+          maxLength: 18,
+        },
+        state: {
+          type: 'string',
+          maxLength: 2,
+        },
+        postalCode: {
+          type: 'string',
+          maxLength: 9,
+        },
+      },
+    },
   },
 };

src/applications/representative-appoint/pages/veteran/veteranContactMailingClaimant.js

@@ -1,4 +1,4 @@
 import {
   addressSchema,
   addressUI,
   titleUI,
@@ -18,8 +18,32 @@
   type: 'object',
   properties: {
     titleSchema,
-    veteranHomeAddress: addressSchema({
-      omit: ['street3'],
-    }),
+    profileNotUpdatedNote: { type: 'object', properties: {} },
+    veteranHomeAddress: {
+      ...addressSchema({ omit: ['street3'] }),
+      properties: {
+        ...addressSchema({ omit: ['street3'] }).properties,
+        street: {
+          type: 'string',
+          maxLength: 30,
+        },
+        street2: {
+          type: 'string',
+          maxLength: 5,
+        },
+        city: {
+          type: 'string',
+          maxLength: 18,
+        },
+        state: {
+          type: 'string',
+          maxLength: 2,
+        },
+        postalCode: {
+          type: 'string',
+          maxLength: 9,
+        },
+      },
+    },
   },
 };

src/applications/representative-appoint/pages/veteran/veteranContactPhoneEmail.js

@@ -1,4 +1,4 @@
 import React from 'react';
 
 import {
   phoneUI,
@@ -30,6 +30,10 @@
     titleSchema,
     profileNotUpdatedNote: { type: 'object', properties: {} },
     primaryPhone: phoneSchema,
-    veteranEmail: emailSchema,
+    veteranEmail: {
+      ...emailSchema,
+      type: 'string',
+      maxLength: 61,
+    },
   },
 };

src/applications/representative-appoint/pages/veteran/veteranIdentification.js

@@ -1,4 +1,4 @@
 import React from 'react';
 
 import {
   ssnUI,
@@ -49,7 +49,13 @@
     descriptionSchema,
     profileNotUpdatedNote: { type: 'object', properties: {} },
     veteranSocialSecurityNumber: ssnSchema,
-    veteranVAFileNumber: vaFileNumberSchema,
-    veteranServiceNumber: serviceNumberSchema,
+    veteranVAFileNumber: {
+      ...vaFileNumberSchema,
+      maxLength: 9,
+    },
+    veteranServiceNumber: {
+      ...serviceNumberSchema,
+      maxLength: 9,
+    },
   },
 };

src/applications/representative-appoint/pages/veteran/veteranPersonalInformation.js

@@ -1,11 +1,10 @@
 import React from 'react';
 import { cloneDeep } from 'lodash';
 
 import {
   dateOfBirthUI,
   dateOfBirthSchema,
   fullNameUI,
-  fullNameSchema,
   titleUI,
   titleSchema,
 } from 'platform/forms-system/src/js/web-component-patterns';
@@ -35,8 +34,25 @@
   properties: {
     titleSchema,
     profileNotUpdatedNote: { type: 'object', properties: {} },
-    veteranFullName: fullNameSchema,
+    veteranFullName: {
+      type: 'object',
+      required: ['first', 'last'],
+      properties: {
+        first: {
+          type: 'string',
+          maxLength: 12,
+        },
+        middle: {
+          type: 'string',
+          maxLength: 1,
+        },
+        last: {
+          type: 'string',
+          maxLength: 18,
+        },
+      },
+    },
     veteranDateOfBirth: dateOfBirthSchema,
   },
-  required: ['veteranDateOfBirth'],
+  required: ['veteranDateOfBirth', 'veteranFullName'],
 };

src/applications/representative-appoint/tests/pages/claimant/claimantContactMailing.unit.spec.jsx

@@ -1,4 +1,4 @@
 import React from 'react';
 import { expect } from 'chai';
 import { render } from '@testing-library/react';
 
@@ -27,4 +27,14 @@
 
     expect($('button[type="submit"]', container)).to.exist;
   });
+
+  it('should have proper max lengths for address fields', () => {
+    const addressProps = schema.properties.homeAddress.properties;
+
+    expect(addressProps.street.maxLength).to.equal(30);
+    expect(addressProps.street2.maxLength).to.equal(5);
+    expect(addressProps.city.maxLength).to.equal(18);
+    expect(addressProps.state.maxLength).to.equal(2);
+    expect(addressProps.postalCode.maxLength).to.equal(9);
+  });
 });

src/applications/representative-appoint/tests/pages/claimant/claimantContactPhoneEmail.unit.spec.jsx

@@ -1,4 +1,4 @@
 import React from 'react';
 import { expect } from 'chai';
 import { render } from '@testing-library/react';
 import { Provider } from 'react-redux';
@@ -34,4 +34,8 @@
 
     expect(container.querySelector('button[type="submit"]')).to.exist;
   });
+
+  it('should have proper max length for email field', () => {
+    expect(schema.properties.applicantEmail.maxLength).to.equal(31);
+  });
 });

src/applications/representative-appoint/tests/pages/claimant/claimantPersonalInformation.unit.spec.jsx

@@ -1,4 +1,4 @@
 import React from 'react';
 import { expect } from 'chai';
 import { render } from '@testing-library/react';
 import { Provider } from 'react-redux';
@@ -37,4 +37,12 @@
 
     expect($('button[type="submit"]', container)).to.exist;
   });
+
+  it('should have proper max lengths for name fields', () => {
+    const nameProps = schema.properties.applicantName.properties;
+
+    expect(nameProps.first.maxLength).to.equal(12);
+    expect(nameProps.middle.maxLength).to.equal(1);
+    expect(nameProps.last.maxLength).to.equal(18);
+  });
 });

src/applications/representative-appoint/tests/pages/claimant/claimantRelationship.unit.spec.jsx

@@ -1,4 +1,4 @@
 import React from 'react';
 import { expect } from 'chai';
 import { render } from '@testing-library/react';
 
@@ -27,4 +27,9 @@
 
     expect($('button[type="submit"]', container)).to.exist;
   });
+
+  it('should have proper max length for relationshipNotListed field', () => {
+    expect(schema.properties.relationshipNotListed.maxLength).to.equal(42);
+    expect(uiSchema.relationshipNotListed['ui:options'].maxLength).to.equal(42);
+  });
 });

src/applications/representative-appoint/tests/pages/veteran/veteranContactMailing.unit.spec.jsx

@@ -1,4 +1,4 @@
 import React from 'react';
 import { render } from '@testing-library/react';
 import { expect } from 'chai';
 import { DefinitionTester } from 'platform/testing/unit/schemaform-utils';
@@ -26,4 +26,14 @@
 
     expect(container.querySelector('button[type="submit"]')).to.exist;
   });
+
+  it('should have proper max lengths for address fields', () => {
+    const addressProps = schema.properties.veteranHomeAddress.properties;
+
+    expect(addressProps.street.maxLength).to.equal(30);
+    expect(addressProps.street2.maxLength).to.equal(5);
+    expect(addressProps.city.maxLength).to.equal(18);
+    expect(addressProps.state.maxLength).to.equal(2);
+    expect(addressProps.postalCode.maxLength).to.equal(9);
+  });
 });

src/applications/representative-appoint/tests/pages/veteran/veteranContactPhoneEmail.unit.spec.jsx

@@ -1,4 +1,4 @@
 import React from 'react';
 import { expect } from 'chai';
 import { render } from '@testing-library/react';
 import { Provider } from 'react-redux';
@@ -34,4 +34,8 @@
 
     expect(container.querySelector('button[type="submit"]')).to.exist;
   });
+
+  it('should have proper max length for email field', () => {
+    expect(schema.properties.veteranEmail.maxLength).to.equal(61);
+  });
 });

src/applications/representative-appoint/tests/pages/veteran/veteranIdentification.unit.spec.jsx

@@ -1,4 +1,4 @@
 import React from 'react';
 import { expect } from 'chai';
 import { render } from '@testing-library/react';
 import { Provider } from 'react-redux';
@@ -34,4 +34,9 @@
 
     expect(container.querySelector('button[type="submit"]')).to.exist;
   });
+
+  it('should have proper max lengths in schema', () => {
+    expect(schema.properties.veteranVAFileNumber.maxLength).to.equal(9);
+    expect(schema.properties.veteranServiceNumber.maxLength).to.equal(9);
+  });
 });

src/applications/representative-appoint/tests/pages/veteran/veteranPersonalInformation.unit.spec.jsx

@@ -1,4 +1,4 @@
 import React from 'react';
 import { expect } from 'chai';
 import { render } from '@testing-library/react';
 import { Provider } from 'react-redux';
@@ -34,4 +34,12 @@
 
     expect(container.querySelector('button[type="submit"]')).to.exist;
   });
+
+  it('should have proper max lengths for name fields', () => {
+    const nameProps = schema.properties.veteranFullName.properties;
+
+    expect(nameProps.first.maxLength).to.equal(12);
+    expect(nameProps.middle.maxLength).to.equal(1);
+    expect(nameProps.last.maxLength).to.equal(18);
+  });
 });