Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add character limits for Appoint a Representative #33725

Merged
merged 15 commits into from
Jan 6, 2025
Merged

Conversation

rjohnson2011
Copy link
Contributor

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

If the folder you changed contains a manifest.json, search for its entryName in the content-build registry.json (the entryName there will match).

If an entry for this folder exists in content-build and you are:

  1. Deleting a folder:

    1. First search vets-website for all instances of the entryName in your manifest.json and remove them in a separate PR. Look particularly for references in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js. If you do not do this, other applications will break!
      • Add the link to your merged vets-website PR here
    2. Then, Delete the application entry in registry.json and merge that PR before this one
      • Add the link to your merged content-build PR here
  2. Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

Implement character limits on the following pages and related fields, as follows:

/claimant-relationship

  • 42 characters for the "Describe your relationship to the Veteran" open input

/claimant-personal-information

  • 12 characters for the First Name
  • 1 character for the Middle Initial
  • 18 characters for the Last Name

/claimant-contact-mailing

  • 30 characters for No. & Street (Street address)
  • 5 characters for Apt./Unit Number (Street address line 2)
  • 18 characters for City
  • 2 characters for State/Province/Region
  • 9 characters for Zip Code/Postal Code

/claimant-contact-phone-email

  • 31 characters for Email address

/veteran-personal-information

  • 12 characters for the First Name
  • 1 character for the Middle Initial
  • 18 characters for the Last Name

/veteran-contact-mailing

  • 30 characters for No. & Street (Street address)
  • 5 characters for Apt./Unit Number (Street address line 2)
  • 18 characters for City
  • 2 characters for State/Province/Region
  • 9 characters for Zip Code/Postal Code

/veteran-contact-phone-email

  • 61 characters for Email address

/veteran-identification

  • 9 characters for Veteran's VA File Number
  • 9 characters for Veteran's Service Number

Related issue(s)

Github Ticket

Testing done

  • Additional max length specs for each attribute changed.

Screenshots

Following showcases the maxChars feature on the Frontend which disables any additional characters being input:
Image

@rjohnson2011 rjohnson2011 requested review from a team as code owners December 20, 2024 18:09
@va-vfs-bot va-vfs-bot temporarily deployed to master/arm-char-limits/main December 23, 2024 17:57 Inactive
cosu419
cosu419 previously approved these changes Jan 2, 2025
Copy link
Contributor

@cosu419 cosu419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - eventually we will need to import these from vets-json-schema rather than declaring them in line here, but saving that for a later PR.

@cosu419 cosu419 self-requested a review January 6, 2025 21:55
@cosu419 cosu419 merged commit 1fe81d3 into main Jan 6, 2025
70 checks passed
@cosu419 cosu419 deleted the arm-char-limits branch January 6, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants