-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[57392] Make phone number optional #26166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds some design tweaks
va-vfs-bot
temporarily deployed
to
master/bdex/57392-make-phone-number-optional_2/main
October 16, 2023 14:03
Inactive
va-vsp-bot
requested a deployment
to
master/bdex/57392-make-phone-number-optional_2/main
October 23, 2023 14:08
In progress
va-vfs-bot
temporarily deployed
to
master/bdex/57392-make-phone-number-optional_2/main
October 23, 2023 14:14
Inactive
va-vsp-bot
requested a deployment
to
master/bdex/57392-make-phone-number-optional_2/main
October 23, 2023 17:49
In progress
va-vfs-bot
temporarily deployed
to
master/bdex/57392-make-phone-number-optional_2/main
October 23, 2023 19:00
Inactive
va-vsp-bot
requested a deployment
to
master/bdex/57392-make-phone-number-optional_2/main
October 23, 2023 21:09
In progress
va-vfs-bot
temporarily deployed
to
master/bdex/57392-make-phone-number-optional_2/main
October 23, 2023 21:48
Inactive
va-vsp-bot
requested a deployment
to
master/bdex/57392-make-phone-number-optional_2/main
October 24, 2023 16:17
In progress
va-vfs-bot
temporarily deployed
to
master/bdex/57392-make-phone-number-optional_2/main
October 24, 2023 17:03
Inactive
va-vfs-bot
temporarily deployed
to
master/bdex/57392-make-phone-number-optional_2/main
November 2, 2023 22:27
Inactive
Mottie
reviewed
Nov 2, 2023
@@ -12,7 +12,8 @@ const PhoneViewField = ({ formData: phoneNumber = '', name }) => { | |||
const phoneString = `${firstPhoneString}-${middlePhoneString}-${lastPhoneString}`; | |||
return ( | |||
<p> | |||
<strong>{name}</strong>: {phoneString} | |||
<strong>{name}</strong>:{' '} | |||
{phoneNumber.trim().length > 0 ? phoneString : ''} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend using the <va-telephone>
web component to render the phone number
va-vfs-bot
temporarily deployed
to
master/bdex/57392-make-phone-number-optional_2/main
November 7, 2023 17:34
Inactive
va-vfs-bot
temporarily deployed
to
master/bdex/57392-make-phone-number-optional_2/main
November 7, 2023 20:21
Inactive
Midge-dev
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
va-vfs-bot
temporarily deployed
to
master/bdex/57392-make-phone-number-optional_2/main
November 8, 2023 14:43
Inactive
…department-of-veterans-affairs/vets-website into bdex/57392-make-phone-number-optional_2
va-vfs-bot
temporarily deployed
to
master/bdex/57392-make-phone-number-optional_2/main
November 8, 2023 19:05
Inactive
va-vfs-bot
temporarily deployed
to
master/bdex/57392-make-phone-number-optional_2/main
November 8, 2023 19:22
Inactive
va-vfs-bot
temporarily deployed
to
master/bdex/57392-make-phone-number-optional_2/main
November 8, 2023 20:09
Inactive
va-vfs-bot
temporarily deployed
to
master/bdex/57392-make-phone-number-optional_2/main
November 8, 2023 21:04
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inputting contact information, make phone number optional to match the 526 paper form.
vets-json-schema PR: department-of-veterans-affairs/vets-json-schema#812
Summary
Related issue(s)
department-of-veterans-affairs/va.gov-team#57392
Testing done
Screenshots
What areas of the site does it impact?
526EZ
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?