Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[57392] Make phone number optional #26166

Merged
merged 39 commits into from
Nov 9, 2023

Conversation

tommasina-va
Copy link
Contributor

@tommasina-va tommasina-va commented Oct 12, 2023

When inputting contact information, make phone number optional to match the 526 paper form.

vets-json-schema PR: department-of-veterans-affairs/vets-json-schema#812

Summary

  • This PR finishes the making of the phone number optional and includes some copy updates regarding phone number.

Related issue(s)

Testing done

  • I tested locally that phone number is not required to continue through the 526 form
  • I tested that behavior stays the same when phone number is filled in
  • I tested on staging that without a phone number, the contact information card is in edit mode, and with a phone number it's in review mode. I also tested that it's not required to continue through the form, and that nothing on the Review and Submit page was affected/changed.

Screenshots

Before After
image image
image image

What areas of the site does it impact?

526EZ

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Also adds some design tweaks
@va-vfs-bot va-vfs-bot temporarily deployed to master/bdex/57392-make-phone-number-optional_2/main October 16, 2023 14:03 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/bdex/57392-make-phone-number-optional_2/main October 23, 2023 14:08 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/bdex/57392-make-phone-number-optional_2/main October 23, 2023 14:14 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/bdex/57392-make-phone-number-optional_2/main October 23, 2023 17:49 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/bdex/57392-make-phone-number-optional_2/main October 23, 2023 19:00 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/bdex/57392-make-phone-number-optional_2/main October 23, 2023 21:09 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/bdex/57392-make-phone-number-optional_2/main October 23, 2023 21:48 Inactive
@tommasina-va tommasina-va marked this pull request as ready for review October 24, 2023 16:14
@tommasina-va tommasina-va requested review from a team as code owners October 24, 2023 16:14
@va-vsp-bot va-vsp-bot requested a deployment to master/bdex/57392-make-phone-number-optional_2/main October 24, 2023 16:17 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/bdex/57392-make-phone-number-optional_2/main October 24, 2023 17:03 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/bdex/57392-make-phone-number-optional_2/main November 2, 2023 22:27 Inactive
@@ -12,7 +12,8 @@ const PhoneViewField = ({ formData: phoneNumber = '', name }) => {
const phoneString = `${firstPhoneString}-${middlePhoneString}-${lastPhoneString}`;
return (
<p>
<strong>{name}</strong>: {phoneString}
<strong>{name}</strong>:{' '}
{phoneNumber.trim().length > 0 ? phoneString : ''}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend using the <va-telephone> web component to render the phone number

@va-vfs-bot va-vfs-bot temporarily deployed to master/bdex/57392-make-phone-number-optional_2/main November 7, 2023 17:34 Inactive
@tommasina-va tommasina-va requested a review from a team as a code owner November 7, 2023 20:00
@va-vfs-bot va-vfs-bot temporarily deployed to master/bdex/57392-make-phone-number-optional_2/main November 7, 2023 20:21 Inactive
Copy link
Contributor

@Midge-dev Midge-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@va-vfs-bot va-vfs-bot temporarily deployed to master/bdex/57392-make-phone-number-optional_2/main November 8, 2023 14:43 Inactive
…department-of-veterans-affairs/vets-website into bdex/57392-make-phone-number-optional_2
@va-vfs-bot va-vfs-bot temporarily deployed to master/bdex/57392-make-phone-number-optional_2/main November 8, 2023 19:05 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/bdex/57392-make-phone-number-optional_2/main November 8, 2023 19:22 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/bdex/57392-make-phone-number-optional_2/main November 8, 2023 20:09 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/bdex/57392-make-phone-number-optional_2/main November 8, 2023 21:04 Inactive
@tommasina-va tommasina-va merged commit 2ee9d82 into main Nov 9, 2023
91 checks passed
@tommasina-va tommasina-va deleted the bdex/57392-make-phone-number-optional_2 branch November 9, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants