Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[57392] Make phone number optional #806

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

tommasina-va
Copy link
Contributor

@tommasina-va tommasina-va commented Oct 12, 2023

New schema

Remove primaryPhone from required fields in order to make it optional.

Zenhub ticket

Pull Requests to update the schema in related repositories

After you've merged your changes to vets-json-schema you'll need to make PR's to vets-website and vets-api. Please link them here.

@tommasina-va tommasina-va marked this pull request as ready for review October 23, 2023 21:27
@tommasina-va tommasina-va requested review from a team as code owners October 23, 2023 21:27
Copy link

@mchae-nava mchae-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sethdarragile6 sethdarragile6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tommasina-va tommasina-va merged commit b66b8ae into master Oct 24, 2023
5 checks passed
@tommasina-va tommasina-va deleted the bdex/57392-make-phone-number-optional_2 branch October 24, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants