Form title 28-8832 -> 25-8832 #25283

DLarson-Oddball · 2023-08-17T23:02:41Z

Summary

Updated form name 28-8832 to 25-8832.
Related PR: department-of-veterans-affairs/content-build#1670

Related issue(s)

department-of-veterans-affairs/va.gov-team#62663

Testing done

Previously, the page title and content included references to form 28-8832. There was also a comparison to form 25-8832 noting they are equivalent forms.
The page title and content now references form 25-8832. The comparison was also updated to form 28-8832.

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

	Before	After
Mobile
Desktop

What areas of the site does it impact?

This PR will not impact pages outside of form 25-8832

Acceptance criteria

Quality Assurance & Testing

I fixed|updated|added unit tests and integration tests for each feature (if applicable). N/A
No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
Linting warnings have been addressed
Documentation has been updated
Screenshot of the developed feature is added
Accessibility testing has been performed

Error Handling

Browser console contains no warnings or errors.
Events are being sent to the appropriate logging solution N/A
Feature/bug has a monitor built into Datadog or Grafana (if applicable) N/A

Authentication

Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

The vets-website header does not contain any web-components
I used the proxy-rewrite steps to test the injected header scenario
I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

src/applications/vre/28-8832/manifest.json

...ions/daily-product-scan/tests/mocks/applications/app-2/app-2b/containers/WizardContainer.jsx

DLarson-Oddball · 2023-09-14T02:28:01Z

@Mottie or @CBonade Hoping you have time to give this another pass. This changes the approach by creating a new app with name 25-8832. Content changes are hosted in this app.

Approach wise, I renamed the original app from 28-8832 to 25-8832 and created a new app named 28-8832. This will preserve git history in an upcoming PR which will remove 28-8832.

Review wise, The new files are copies of those in 28-8832 with some small copy changes.

...ions/vre/25-8832/tests/config/claimant-information/static-claimant-information.unit.spec.jsx

+import React from 'react';
+import { expect } from 'chai';
+import { mount } from 'enzyme';
+import staticClaimantInformation from '../../../config/chapters/claimant-information/staticClaimantComponent.jsx';


Mottie · 2023-09-14T21:20:08Z

src/applications/vre/25-8832/config/form.js

+  rootUrl: manifest.rootUrl,
+  urlPrefix: '/',
+  submitUrl: `${environment.API_URL}/v0/education_career_counseling_claims`,
+  trackingPrefix: 'careers-employment-28-8832--',


Are you planning on updating this tracking prefix?

Not currently unless you feel can include this without impacting other teams.

I'm not sure what it's used for, and our ask really only covers changing the page content.

src/applications/vre/25-8832/config/form.js

Mottie · 2023-09-14T21:25:35Z

src/applications/vre/25-8832/config/form.js

@@ -0,0 +1,116 @@
+import fullSchema from 'vets-json-schema/dist/28-8832-schema.json';


Probably won't need to update vets-json-schema any time soon

Can you expand what you mean by this?

src/applications/vre/25-8832/containers/ConfirmationPage.jsx

src/applications/vre/25-8832/containers/WizardContainer.jsx

src/applications/vre/25-8832/containers/IntroductionPage.jsx

src/applications/vre/25-8832/tests/e2e/formDataSets/veteran-workflow-test.json

src/applications/vre/28-8832/containers/WizardContainer.jsx

This reverts commit 0d30081.

Form title 28-8832 -> 25-8832

367ea7d

DLarson-Oddball mentioned this pull request Aug 17, 2023

Form title 28-8832 -> 25-8832 department-of-veterans-affairs/content-build#1670

Merged

9 tasks

fred-khoury-oddball approved these changes Aug 18, 2023

View reviewed changes

DLarson-Oddball and others added 2 commits August 18, 2023 17:05

Update URL

3c9c5b6

Merge branch 'main' into 62663-ch36-form-name-change

5a98312

DLarson-Oddball marked this pull request as ready for review August 19, 2023 00:34

DLarson-Oddball requested a review from a team August 19, 2023 00:34

DLarson-Oddball requested a review from a team as a code owner August 19, 2023 00:34

va-vsp-bot requested a deployment to master/62663-ch36-form-name-change/main August 19, 2023 00:35 In progress

va-vfs-bot temporarily deployed to master/62663-ch36-form-name-change/62663-ch36-form-name-change August 19, 2023 00:36 Inactive

platform-support-slack-integration bot mentioned this pull request Aug 23, 2023

May I please have a PR review on this PR: https://github.com... department-of-veterans-affairs/va.gov-team#64129

Closed

Merge branch 'main' into 62663-ch36-form-name-change

e733086

va-vsp-bot requested a deployment to master/62663-ch36-form-name-change/main August 23, 2023 18:52 In progress

va-vfs-bot temporarily deployed to master/62663-ch36-form-name-change/62663-ch36-form-name-change August 23, 2023 19:28 Inactive

va-vsp-bot requested a deployment to master/62663-ch36-form-name-change/main August 23, 2023 20:12 In progress

Merge branch 'main' into 62663-ch36-form-name-change

a24d507

fred-khoury-oddball force-pushed the 62663-ch36-form-name-change branch from 614978a to a24d507 Compare August 23, 2023 20:15

va-vsp-bot requested a deployment to master/62663-ch36-form-name-change/main August 23, 2023 20:17 In progress

va-vfs-bot temporarily deployed to master/62663-ch36-form-name-change/62663-ch36-form-name-change August 23, 2023 20:32 Inactive

platform-support-slack-integration bot mentioned this pull request Aug 23, 2023

I would like to request a PR review please: https://github.c... department-of-veterans-affairs/va.gov-team#64183

Closed

Mottie approved these changes Aug 24, 2023

View reviewed changes

src/applications/vre/28-8832/manifest.json Outdated Show resolved Hide resolved

Mottie reviewed Aug 24, 2023

View reviewed changes

...ions/daily-product-scan/tests/mocks/applications/app-2/app-2b/containers/WizardContainer.jsx Outdated Show resolved Hide resolved

CBonade approved these changes Aug 24, 2023

View reviewed changes

Merge branch 'main' into 62663-ch36-form-name-change

f6b80a4

va-vsp-bot requested a deployment to master/62663-ch36-form-name-change/main August 28, 2023 15:27 In progress

va-vfs-bot temporarily deployed to master/62663-ch36-form-name-change/62663-ch36-form-name-change August 28, 2023 15:29 Inactive

Revert QA file change

a94090d

va-vsp-bot requested a deployment to master/62663-ch36-form-name-change/main August 28, 2023 20:31 In progress

va-vfs-bot temporarily deployed to master/62663-ch36-form-name-change/62663-ch36-form-name-change August 28, 2023 20:42 Inactive

Merge branch '62663-url-update' into 62663-ch36-form-name-change

37a411c

DLarson-Oddball added 3 commits September 13, 2023 17:03

Clone 25-8832 and rename 28-8832

d05a6e1

Revert content changes

ef70fbe

Rename scss file

ca4a356

va-vfs-bot temporarily deployed to master/62663-ch36-form-name-change/62663-ch36-form-name-change September 14, 2023 02:16 Inactive

va-vsp-bot requested a deployment to master/62663-ch36-form-name-change/main September 14, 2023 02:16 In progress

Cleanup

d603559

va-vsp-bot requested a deployment to master/62663-ch36-form-name-change/main September 14, 2023 02:20 In progress

Merge branch 'main' into 62663-ch36-form-name-change

afb57d8

va-vfs-bot temporarily deployed to master/62663-ch36-form-name-change/62663-ch36-form-name-change September 14, 2023 02:22 Inactive

va-vsp-bot requested a deployment to master/62663-ch36-form-name-change/main September 14, 2023 02:23 In progress

va-vfs-bot temporarily deployed to master/62663-ch36-form-name-change/62663-ch36-form-name-change September 14, 2023 02:27 Inactive

github-advanced-security bot found potential problems Sep 14, 2023

View reviewed changes

Mottie approved these changes Sep 14, 2023

View reviewed changes

DLarson-Oddball added 2 commits September 15, 2023 17:32

Update form id

0d30081

Update email addresses

a211b9c

DLarson-Oddball requested review from a team as code owners September 16, 2023 00:33

va-vsp-bot requested a deployment to master/62663-ch36-form-name-change/main September 16, 2023 00:34 In progress

va-vfs-bot temporarily deployed to master/62663-ch36-form-name-change/62663-ch36-form-name-change September 16, 2023 00:34 Inactive

Merge branch 'main' into 62663-ch36-form-name-change

c4e212c

va-vsp-bot requested a deployment to master/62663-ch36-form-name-change/main September 16, 2023 00:35 In progress

va-vfs-bot temporarily deployed to master/62663-ch36-form-name-change/62663-ch36-form-name-change September 16, 2023 00:39 Inactive

Revert "Update form id"

d370417

This reverts commit 0d30081.

DLarson-Oddball removed request for a team September 16, 2023 00:42

va-vsp-bot requested a deployment to master/62663-ch36-form-name-change/main September 16, 2023 00:43 In progress

va-vfs-bot temporarily deployed to master/62663-ch36-form-name-change/62663-ch36-form-name-change September 16, 2023 00:44 Inactive

DLarson-Oddball merged commit 1afcda4 into main Sep 16, 2023

DLarson-Oddball deleted the 62663-ch36-form-name-change branch September 16, 2023 01:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Form title 28-8832 -> 25-8832 #25283

Form title 28-8832 -> 25-8832 #25283

DLarson-Oddball commented Aug 17, 2023 •

edited

Loading

DLarson-Oddball commented Sep 14, 2023

Mottie Sep 14, 2023

DLarson-Oddball Sep 16, 2023 •

edited

Loading

Mottie Sep 14, 2023

DLarson-Oddball Sep 16, 2023

		@@ -0,0 +1,116 @@
		import fullSchema from 'vets-json-schema/dist/28-8832-schema.json';

Form title 28-8832 -> 25-8832 #25283

Form title 28-8832 -> 25-8832 #25283

Conversation

DLarson-Oddball commented Aug 17, 2023 • edited Loading

Summary

Related issue(s)

Testing done

Screenshots

What areas of the site does it impact?

Acceptance criteria

Quality Assurance & Testing

Error Handling

Authentication

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

Requested Feedback

DLarson-Oddball commented Sep 14, 2023

Mottie Sep 14, 2023

Choose a reason for hiding this comment

DLarson-Oddball Sep 16, 2023 • edited Loading

Choose a reason for hiding this comment

Mottie Sep 14, 2023

Choose a reason for hiding this comment

DLarson-Oddball Sep 16, 2023

Choose a reason for hiding this comment

DLarson-Oddball commented Aug 17, 2023 •

edited

Loading

DLarson-Oddball Sep 16, 2023 •

edited

Loading