Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form title 28-8832 -> 25-8832 #1670

Merged
merged 8 commits into from
Sep 19, 2023
Merged

Conversation

DLarson-Oddball
Copy link
Contributor

Description

Updates breadcrumbs, title and app name of form 28-8832 to 25-8832

closes department-of-veterans-affairs/va.gov-team#62663
relates to department-of-veterans-affairs/vets-website#25283

Testing done & Screenshots

image

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked? N/A, global change.

  1. Do this
    • Complete form 25-8832 /careers-employment/education-and-career-counseling/apply-career-guidance-form-28-8832/introduction
    • Ensure breadcrumb link still works
    • Ensure page title is properly set
  2. Then validate Acceptance Criteria from issue

Acceptance criteria

  • Page title is updated
  • Breadcrumb text is updated, and link is still valid.

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@va-vfs-bot va-vfs-bot temporarily deployed to master/62663-ch36-form-name-change/62663-ch36-form-name-change August 19, 2023 00:21 Inactive
@DLarson-Oddball DLarson-Oddball marked this pull request as ready for review August 19, 2023 00:34
@DLarson-Oddball DLarson-Oddball requested review from a team as code owners August 19, 2023 00:34
@va-vfs-bot va-vfs-bot temporarily deployed to master/62663-ch36-form-name-change/62663-ch36-form-name-change August 25, 2023 17:12 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/62663-ch36-form-name-change/62663-ch36-form-name-change August 25, 2023 19:17 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/62663-ch36-form-name-change/62663-ch36-form-name-change August 25, 2023 19:56 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/62663-ch36-form-name-change/62663-ch36-form-name-change September 1, 2023 00:23 Inactive
@DLarson-Oddball
Copy link
Contributor Author

@powellkerry @teeshe I refactored my approach to adding a new entry for the form name change so I wanted to re-request your review.

After merge of this PR, I will merge department-of-veterans-affairs/vets-website#25283 along with a devops PR to create a redirect.

@DLarson-Oddball DLarson-Oddball merged commit 34965c6 into main Sep 19, 2023
21 checks passed
@DLarson-Oddball DLarson-Oddball deleted the 62663-ch36-form-name-change branch September 19, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CH36 Form Name Changes
5 participants