Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor loan history schema #23372

Closed
wants to merge 1 commit into from

Conversation

data-doge
Copy link
Contributor

Summary

Refactoring loan history schema. See department-of-veterans-affairs/vets-json-schema#748. After updating vets-json-schema to include the changes to the loan history form, we can remove a little bit of hard-coded code.

I'm on the Benefits decision reviews team, which is currently responsible for the COE form.

Related issue(s)

Testing done

Screenshots

Note: This field is mandatory for component work and UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

COE form.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature
  • Accessibility foundational testing has been performed

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

See department-of-veterans-affairs/vets-json-schema#748. After updating vets-json-schema to include the changes to the loan history form, we can remove a little bit of hard-coded code.
@github-actions
Copy link

This PR is stale because it has been open 120 days with no activity. It will recieve a stale label every day for 14 days before being closed unless it recieves a comment or the stale label is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant