Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tech task] CoE | Transition work to new team #60243

Closed
6 of 11 tasks
saderagsdale opened this issue Jun 14, 2023 · 4 comments
Closed
6 of 11 tasks

[tech task] CoE | Transition work to new team #60243

saderagsdale opened this issue Jun 14, 2023 · 4 comments
Assignees
Labels
bmt-team-1 Benefits Management Tools Team #1 Decision-Reviews-Team (Formerly squad-2) Label for issues being worked on by Decision Reviews on BMT & DR team non-disability-benefits

Comments

@saderagsdale
Copy link
Contributor

saderagsdale commented Jun 14, 2023

(assign to Fred when ready)

Value Statement

As the new team responsible for the Certificate of Eligibility
I want to have sufficient context on past, present, and planned COE work
So that I can pick up where the previous team left off, without anything falling through the cracks.

Background Context

We are transitioning COE work to a new team. Please see the following list of tasks for more detail on what is necessary to get the new team up to speed.

Tasks

  • Give new team a list of contacts who may be helpful during the COE work.
  • Give new team Sentry dashboards related to COE work and provide context.
  • Invite new team to "VA.GOV-LGY COE Group-Production" Teams chat and #evss-prod channel on Slack.
  • Show new team how to set up downtime notifications for COE.
  • Give new team a list of outstanding COE work.
  • Give new team a tour of relevant COE code and record a video of this tour for their future reference.

Definition of Ready

  • Eugene knows who the new team is and who specifically will be working on COE.
  • The new COE team has access to VA remote desktop, VA Github, VA Slack, VA Datadog, VA Sentry, VA pager duty, and VA Argo CD.

Definition of Done

  • Relevant documentation has been updated to reflect the current state of COE work.
  • New team added to all channels, meetings, documents, and dashboards referenced above, and is sufficiently familiar therewith.
  • Team's engineers are sufficiently familiar with the COE code.
@saderagsdale saderagsdale added the bmt-team-1 Benefits Management Tools Team #1 label Jun 14, 2023
@saderagsdale saderagsdale added needs-grooming Use this to designate any issues that need grooming from the team Decision-Reviews-Team (Formerly squad-2) Label for issues being worked on by Decision Reviews on BMT & DR team labels Jun 14, 2023
@saderagsdale saderagsdale changed the title CoE | Transition work to new team [tech task] CoE | Transition work to new team Jun 14, 2023
@data-doge
Copy link
Contributor

data-doge commented Jun 14, 2023

List of Contacts:

The following people are responsible for the COE Form, on the LGY side. They will probably be able to answer any questions you have and direct you to others who can help. You should also feel free to reach out to me.

Name Email Role
Kris Kelleher [email protected] Scrum Master
Kelli Deinarowicz [email protected] Product Manager

Sentry Dashboard:

http://sentry.vfs.va.gov/organizations/vsp/dashboard/8/?environment=production&project=3&statsPeriod=7d

Downtime Notifications

LGY Announcements Page: https://lgy.va.gov/lgyhub/announcements (where some downtime periods are announced). See also #evss-prod in Slack.

Pager Duty: https://dsva.pagerduty.com/service-directory/PCT7A0L/activity?welcome=1 (See "Maintenance Windows")

Before setting a maintenance window, ask LGY, in the "VA.GOV-LGY COE Group-Production" Team chat, how long the maintenance window should be.

App Entry Points

vets-api: https://github.com/department-of-veterans-affairs/vets-api/blob/master/app/controllers/v0/coe_controller.rb

vets-website: https://github.com/department-of-veterans-affairs/vets-website/tree/main/src/applications/lgy/coe

Outstanding Work

Along with the open tickets here: https://github.com/department-of-veterans-affairs/va.gov-team/issues?q=is%3Aopen+is%3Aissue+label%3ACOE, here is a list of other work that you may consider ticketing and throwing in a backlog.

Description Notes
Troubleshooting 400 and 404 errors on GET /determination and PUT /application endpoints. If you have a look at Sentry, you'll see the errors referenced in the description. Some portion of these errors (perhaps most) may be due to a discrepancy between VA.gov's EDIPIs and VADIR's APIs. For VADIR-related inquiries you can try reaching out to [email protected] (SRA) and [email protected] (VADIR PM). In case you find it helpful, just before I moved off this work in February, I began drafting a PR to improve our COE logging, to help debug these 400 and 404 issues. Feel free to re-open that PR: department-of-veterans-affairs/vets-api#11766.
Handling non-US uploads The COE Form currently does not permit veterans domiciled in a foreign country, but not on a US military base, to apply for a COE. Jyssica, an LGY tester ([email protected]), believes that such veterans should be allowed to apply for a COE.
Fix flaky COE keyboard tests See #52760
Fix hard-coded parts of the COE form Tech-debt work. Before I had to move off COE, I was in the middle of transitioning some hard-coded changes we had made to the COE schema on the front end, into our vets-json-schema gem. Here are some breadcrumbs for that work: #53281; department-of-veterans-affairs/vets-website#23372; department-of-veterans-affairs/vets-api#11075; department-of-veterans-affairs/vets-json-schema#748.

Other notes

You may find it useful to read through https://github.com/department-of-veterans-affairs/va.gov-team-sensitive/issues/628. There's plenty of useful context around the COE form in there.

@steele-lm steele-lm added the Umbrella Non-disability benefits team label Jun 14, 2023
@saderagsdale saderagsdale removed the needs-grooming Use this to designate any issues that need grooming from the team label Jun 15, 2023
@saderagsdale
Copy link
Contributor Author

@steele-lm @data-doge anything else we need to do with this item or can it be closed?

@steele-lm
Copy link
Contributor

@saderagsdale I confirmed that there are still open tasks on this ticket that need to be completed before closing.

@saderagsdale
Copy link
Contributor Author

Original purpose fulfilled. We can open a new ticket for additional work. @steele-lm

@steele-lm steele-lm added non-disability-benefits and removed Umbrella Non-disability benefits team labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bmt-team-1 Benefits Management Tools Team #1 Decision-Reviews-Team (Formerly squad-2) Label for issues being worked on by Decision Reviews on BMT & DR team non-disability-benefits
Projects
None yet
Development

No branches or pull requests

3 participants