Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VA-10656] Remove facility_locator_predictive_location_search flipper #22759

Closed
wants to merge 2 commits into from
Closed

[VA-10656] Remove facility_locator_predictive_location_search flipper #22759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
636d56e
VA-10656: Remove predictive search flipper from Facilities Map
maxx1128 Nov 22, 2022
3034380
VA-10656: Remove geo predictive search flipper
maxx1128 Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/applications/facility-locator/actions/mapbox/genBBoxFromAddress.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,7 @@ export const genBBoxFromAddress = (query, expandedRadius = false) => {

dispatch({
type: GEOCODE_COMPLETE,
payload: query.usePredictiveGeolocation
? features.map(feature => ({
placeName: feature.place_name,
placeType: feature.place_type[0],
bbox: feature.bbox,
center: feature.center,
}))
: [],
payload: [],
});

const searchBoundingRadius = expandedRadius
Expand Down
9 changes: 2 additions & 7 deletions src/applications/facility-locator/containers/FacilitiesMap.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import {
facilitiesPpmsSuppressAll,
facilitiesPpmsSuppressCommunityCare,
facilitiesPpmsSuppressPharmacies,
facilityLocatorPredictiveLocationSearch,
facilityLocatorLighthouseCovidVaccineQuery,
} from '../utils/featureFlagSelectors';
import ResultsList from '../components/ResultsList';
Expand Down Expand Up @@ -438,11 +437,8 @@ const FacilitiesMap = props => {
<div id="search-result-emergency-care-info">
<p className="search-result-emergency-care-subheader">
<strong>Note:</strong> If you think your life or health is in
danger, call{' '}
<a aria-label="9 1 1" href="tel:911">
911
</a>{' '}
or go to the nearest emergency department right away.
danger, call <va-telephone contact="911" /> or go to the nearest
emergency department right away.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to undo this change since it's out of scope for this PR, but each fixup commit ignores the changes and sees it as an "empty commit."

</p>
</div>
)}
Expand Down Expand Up @@ -667,7 +663,6 @@ const mapStateToProps = state => ({
suppressPPMS: facilitiesPpmsSuppressAll(state),
suppressPharmacies: facilitiesPpmsSuppressPharmacies(state),
suppressCCP: facilitiesPpmsSuppressCommunityCare(state),
usePredictiveGeolocation: facilityLocatorPredictiveLocationSearch(state),
searchCovid19Vaccine: facilityLocatorLighthouseCovidVaccineQuery(state),
results: state.searchResult.results,
searchError: state.searchResult.error,
Expand Down
5 changes: 0 additions & 5 deletions src/applications/facility-locator/utils/featureFlagSelectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,6 @@ export const facilitiesPpmsSuppressPharmacies = state =>
export const facilitiesPpmsSuppressCommunityCare = state =>
toggleValues(state)[FEATURE_FLAG_NAMES.facilitiesPpmsSuppressCommunityCare];

export const facilityLocatorPredictiveLocationSearch = state =>
toggleValues(state)[
FEATURE_FLAG_NAMES.facilityLocatorPredictiveLocationSearch
];

export const facilityLocatorLighthouseCovidVaccineQuery = state =>
toggleValues(state)[
FEATURE_FLAG_NAMES.facilityLocatorLighthouseCovidVaccineQuery
Expand Down
2 changes: 0 additions & 2 deletions src/platform/utilities/feature-toggles/featureFlagNames.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ export default Object.freeze({
facilityLocatorLighthouseCovidVaccineQuery:
'facility_locator_lighthouse_covid_vaccine_query',
facilityLocatorShowHealthConnectNumber: 'facility_locator_show_health_connect_number',
facilityLocatorPredictiveLocationSearch:
'facility_locator_predictive_location_search',
facilityLocatorRailsEngine: 'facility_locator_rails_engine',
facilityLocatorRestoreCommunityCarePagination:
'facility_locator_restore_community_care_pagination',
Expand Down