[VA-10656] Remove facility_locator_predictive_location_search flipper #22759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/va-10656-remove-facility-predictive-search-flipper/main
it-harrison
approved these changes
Nov 22, 2022
|
This flipper is set to "off" in production, so I'm adding another commit to remove the front-end functionality as well. UPDATE: There's no front-end HTML code related to this PR, so it's already good to go once the tests pass. |
maxx1128
commented
Nov 28, 2022
| </a>{' '} | ||
| or go to the nearest emergency department right away. | ||
| danger, call <va-telephone contact="911" /> or go to the nearest | ||
| emergency department right away. |
There was a problem hiding this comment.
I've tried to undo this change since it's out of scope for this PR, but each fixup commit ignores the changes and sees it as an "empty commit."
jtmst
approved these changes
Nov 28, 2022
|
This PR is stale because it has been open 120 days with no activity. It will recieve a stale label every day for 14 days before being closed unless it recieves a comment or the stale label is removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
facility_locator_predictive_location_searchflipper was explored but never fully implemented, so the front-end code for it is good to remove.Original issue(s)
department-of-veterans-affairs/va.gov-cms#10656
Testing done
Code search
Acceptance criteria
facility_locator_predictive_location_searchare removed from the front-end without anything breaking.Definition of done